GNOME Bugzilla – Bug 741661
Version check rejects NetworkManager 1.x
Last modified: 2015-01-15 14:06:29 UTC
It seems the network panel requires NetworkManager 0.9.x and rejects the recent 1.0-rc1 release. /* is it too new or old */ if (major > 0 || minor > 9 || (minor <= 8 && micro < 992)) { It should work fine with 1.0 though (I've used it frequently with 0.9.11-git).
Created attachment 292954 [details] [review] network: We also work with NM 1.0
Comment on attachment 292954 [details] [review] network: We also work with NM 1.0 >+ if (major > 0) >+ goto out; >+ >+ /* is it too new or old >+ * major == 0 is implied */ >+ if (minor > 9 || (minor <= 8 && micro < 992)) { > ret = FALSE; It's weird to say that 1.0 is fine but 0.10 is too new... And at any rate, at this point there won't ever be a version with major == 0 and minor > 9 anyway. And 0.8.992 is a 4-year-old beta release of 0.9.0. While it may happen to be the case that it's the first version that has all of the APIs the control-center wants, there's really no reason to be checking that precisely at this point. So I'd say just if (major == 0 && minor < 9) ret = FALSE Or just remove the whole thing... you already require libnm-glib 0.9.8, and it would be bizarre to have a machine with the 0.9.8 libraries but a 0.8.x daemon.
Created attachment 293885 [details] [review] network: Also work with NM 1.0 Remove the NetworkManager version checking altogether. The code was made to check for now very old versions of NetworkManager, and anything newer than ancient should degrade gracefully if we support newer features.
Review of attachment 293885 [details] [review]: fine
Attachment 293885 [details] pushed as f30e6df - network: Also work with NM 1.0
Pushed to gnome-3-8 and all the newer branches.