After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741661 - Version check rejects NetworkManager 1.x
Version check rejects NetworkManager 1.x
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-17 16:18 UTC by Mantas Mikulėnas (grawity)
Modified: 2015-01-15 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
network: We also work with NM 1.0 (1.24 KB, patch)
2014-12-18 07:11 UTC, Bastien Nocera
none Details | Review
network: Also work with NM 1.0 (2.20 KB, patch)
2015-01-05 23:55 UTC, Bastien Nocera
committed Details | Review

Description Mantas Mikulėnas (grawity) 2014-12-17 16:18:35 UTC
It seems the network panel requires NetworkManager 0.9.x and rejects the recent 1.0-rc1 release.

        /* is it too new or old */
        if (major > 0 || minor > 9 || (minor <= 8 && micro < 992)) {

It should work fine with 1.0 though (I've used it frequently with 0.9.11-git).
Comment 1 Bastien Nocera 2014-12-18 07:11:07 UTC
Created attachment 292954 [details] [review]
network: We also work with NM 1.0
Comment 2 Dan Winship 2014-12-18 10:56:32 UTC
Comment on attachment 292954 [details] [review]
network: We also work with NM 1.0

>+        if (major > 0)
>+                goto out;
>+
>+        /* is it too new or old
>+         * major == 0 is implied */
>+        if (minor > 9 || (minor <= 8 && micro < 992)) {
>                 ret = FALSE;

It's weird to say that 1.0 is fine but 0.10 is too new... And at any rate, at this point there won't ever be a version with major == 0 and minor > 9 anyway.

And 0.8.992 is a 4-year-old beta release of 0.9.0. While it may happen to be the case that it's the first version that has all of the APIs the control-center wants, there's really no reason to be checking that precisely at this point.

So I'd say just

    if (major == 0 && minor < 9)
        ret = FALSE

Or just remove the whole thing... you already require libnm-glib 0.9.8, and it would be bizarre to have a machine with the 0.9.8 libraries but a 0.8.x daemon.
Comment 3 Bastien Nocera 2015-01-05 23:55:48 UTC
Created attachment 293885 [details] [review]
network: Also work with NM 1.0

Remove the NetworkManager version checking altogether. The code was made
to check for now very old versions of NetworkManager, and anything newer
than ancient should degrade gracefully if we support newer features.
Comment 4 Rui Matos 2015-01-06 14:33:56 UTC
Review of attachment 293885 [details] [review]:

fine
Comment 5 Bastien Nocera 2015-01-15 14:02:40 UTC
Attachment 293885 [details] pushed as f30e6df - network: Also work with NM 1.0
Comment 6 Bastien Nocera 2015-01-15 14:06:29 UTC
Pushed to gnome-3-8 and all the newer branches.