After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741659 - ifcfg-rh test/internal API simplifications [danw/ifcfg-rh-cleanup-bgo....]
ifcfg-rh test/internal API simplifications [danw/ifcfg-rh-cleanup-bgo....]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Distro-specific
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-12-17 15:24 UTC by Dan Winship
Modified: 2015-01-12 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Winship 2014-12-17 15:24:39 UTC
I started this while working on rh#1160013, but it then turned out to be completely irrelevant to that...

Obviously not 1.0.0 material, but assuming this does land on master soon, I think we'd probably want to cherry-pick it to nm-1-0 after 1.0.0 goes out, to simplify later cherry-picks.
Comment 1 Thomas Haller 2014-12-17 15:44:16 UTC
looks all good to me
Comment 2 Dan Williams 2014-12-17 16:07:04 UTC
LGTM.  I agree we'll probably want to cherry-pick back to 1.0.x just to minimize the diff.
Comment 3 Jiri Klimes 2014-12-18 13:48:34 UTC
The branch looks good to me and works fine.
Comment 4 Dan Winship 2014-12-18 16:36:26 UTC
pushed as e531fb2f88ff0190b7018e8de370341d9f0561e7