After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741558 - Add -Werror=return-type to base_error_flags
Add -Werror=return-type to base_error_flags
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-12-15 15:44 UTC by Ting-Wei Lan
Modified: 2014-12-15 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
compiler-warnings: Add -Werror=return-type (871 bytes, patch)
2014-12-15 15:44 UTC, Ting-Wei Lan 		reviewed Details | Review

Description Ting-Wei Lan 2014-12-15 15:44:24 UTC 
Created attachment 292756 [details] [review]
compiler-warnings: Add -Werror=return-type

As we have got nearly 20 bug reports related to function return type mismatch in this year (searching for 'void' on https://wiki.gnome.org/Projects/Jhbuild/FreeBSD), I hope we can add -Werror=return-type to base_error_flags. Reporting the same problem in different modules repeatedly is a boring task.

I know GCC still cannot catch all issues using -Werror=return-type in GCC, but having it is better than not using it.
Comment 1 David King 2014-12-15 17:45:23 UTC 
Review of attachment 292756 [details] [review]:

Seems reasonable to me. I just did a trial with jhbuild, and did not run into problems with around 100 packages. When you push, please make sure to bump the M4 serial in the file.
Comment 2 Ting-Wei Lan 2014-12-15 17:50:24 UTC 
(In reply to comment #1)
> Review of attachment 292756 [details] [review]:
> 
> Seems reasonable to me. I just did a trial with jhbuild, and did not run into
> problems with around 100 packages. 

Yes, problems in most packages are already fixed.

> When you push, please make sure to bump the
> M4 serial in the file.

Do you mean I should change it to 'serial 3'?
Comment 3 David King 2014-12-15 17:52:30 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > When you push, please make sure to bump the
> > M4 serial in the file.
> 
> Do you mean I should change it to 'serial 3'?

Yes, please!