After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741553 - curlsmtpsink: final boundary only added to last mail
curlsmtpsink: final boundary only added to last mail
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-15 15:15 UTC by Branko Subasic
Modified: 2014-12-19 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch that fixes the issue (4.96 KB, patch)
2014-12-15 15:39 UTC, Branko Subasic 		committed Details | Review

Description Branko Subasic 2014-12-15 15:15:11 UTC 
In SMTP uploads spanning over multiple emails each email should be ended by a final boundary. This does not work properly. Instead, the final boundary is only added to the last email.
Comment 1 Branko Subasic 2014-12-15 15:39:39 UTC 
Created attachment 292755 [details] [review]
Proposed patch that fixes the issue

After each buffer is completed check if we've reached max buffers per email. If so then add the final boundary. When EOS is received only send final boundary if it's not already sent (i.e. as a result of max buffers per email reached). 
 
Also simplified, and corrected, how we keep track of the number of attachments sent/left.
Comment 2 Tim-Philipp Müller 2014-12-19 13:17:51 UTC 
Pushed to master, thanks:

commit f00d21aec5ed524052a5f5c52e764a57e74fda05
Author: Branko Subasic <branko@axis.com>
Date:   Mon Dec 15 16:27:16 2014 +0100

    curlsmtpsink: add final boundary to all multipart emails
    
    Corrected the final boundary mechanism so that a final boundary is
    added to each mail with multipart content that is sent,
    not just to the last one.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=741553