After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741537 - Some trivial bugfixes for 'jhbuild sysdeps'
Some trivial bugfixes for 'jhbuild sysdeps'
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks: 691394 742266
 
 
Reported: 2014-12-15 00:45 UTC by Allison Karlitskaya (desrt)
Modified: 2015-01-03 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
i18n: fix two improperly marked translated strings (1.36 KB, patch)
2014-12-15 00:46 UTC, Allison Karlitskaya (desrt)
committed Details | Review
systeminstall: fix prototype of 'install' method (1.14 KB, patch)
2014-12-15 00:46 UTC, Allison Karlitskaya (desrt)
committed Details | Review
sysdeps: fix indentation of a line in the output (1.36 KB, patch)
2014-12-15 00:46 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-12-15 00:45:58 UTC
See patches.
Comment 1 Allison Karlitskaya (desrt) 2014-12-15 00:46:00 UTC
Created attachment 292718 [details] [review]
i18n: fix two improperly marked translated strings

We need to call gettext() on the untranslated string before doing the
formatting.  It won't work if we do it after.
Comment 2 Allison Karlitskaya (desrt) 2014-12-15 00:46:04 UTC
Created attachment 292719 [details] [review]
systeminstall: fix prototype of 'install' method

Fix the prototype of the 'install' method on the base class of
SystemInstall.  This is a pretty theoretical problem because this
function will throw a NotImplementedError if it is ever called anyway.
Comment 3 Allison Karlitskaya (desrt) 2014-12-15 00:46:10 UTC
Created attachment 292720 [details] [review]
sysdeps: fix indentation of a line in the output

The output looked like the following:

  Optional packages: (JHBuild will build the missing packages):
    System installed packages which are too old:
      (none)
    No matching system package installed:
    (none)

vs. all of the other cases of '(none)' which were indented one further.

Fix this one so that it looks like:

  Optional packages: (JHBuild will build the missing packages):
    System installed packages which are too old:
      (none)
    No matching system package installed:
      (none)

like the others.
Comment 4 Allison Karlitskaya (desrt) 2015-01-02 14:48:49 UTC
Attachment 292718 [details] pushed as d6eecde - i18n: fix two improperly marked translated strings
Attachment 292719 [details] pushed as 0db862a - systeminstall: fix prototype of 'install' method
Attachment 292720 [details] pushed as 49f702c - sysdeps: fix indentation of a line in the output

Pushed these because they truly are trivial and they're causing patches
in other bugs to conflict.

Sorry if I got anything wrong...