GNOME Bugzilla – Bug 741537
Some trivial bugfixes for 'jhbuild sysdeps'
Last modified: 2015-01-03 16:29:15 UTC
See patches.
Created attachment 292718 [details] [review] i18n: fix two improperly marked translated strings We need to call gettext() on the untranslated string before doing the formatting. It won't work if we do it after.
Created attachment 292719 [details] [review] systeminstall: fix prototype of 'install' method Fix the prototype of the 'install' method on the base class of SystemInstall. This is a pretty theoretical problem because this function will throw a NotImplementedError if it is ever called anyway.
Created attachment 292720 [details] [review] sysdeps: fix indentation of a line in the output The output looked like the following: Optional packages: (JHBuild will build the missing packages): System installed packages which are too old: (none) No matching system package installed: (none) vs. all of the other cases of '(none)' which were indented one further. Fix this one so that it looks like: Optional packages: (JHBuild will build the missing packages): System installed packages which are too old: (none) No matching system package installed: (none) like the others.
Attachment 292718 [details] pushed as d6eecde - i18n: fix two improperly marked translated strings Attachment 292719 [details] pushed as 0db862a - systeminstall: fix prototype of 'install' method Attachment 292720 [details] pushed as 49f702c - sysdeps: fix indentation of a line in the output Pushed these because they truly are trivial and they're causing patches in other bugs to conflict. Sorry if I got anything wrong...