GNOME Bugzilla – Bug 741504
Improve the "Save changes before closing?" dialog when more than one Unsaved Document
Last modified: 2020-11-24 09:59:01 UTC
- Open two new tabs in gedit and write some text in them. - Try to close the window. - A dialog window appears with "There are 2 documents with unsaved changes. Save changes before closing?", with checkboxes to select the two Unsaved Documents. There are three buttons: "Close without saving", "Cancel" and "Save". If we click on "Save", a "save as" dialog window appears to save the first Unsaved Document, then a second "save as" dialog for the second Unsaved Document. The problem is that it's difficult to see the contents of the Unsaved Documents, so it's difficult to choose good file names. The best option I think is to click on "Cancel" and take the time to save the Unsaved Documents manually, by first looking at their contents (and be able to scroll the documents), and then choose suitable names. So I think in that case (when there are several Unsaved Documents to save), the "Save" button should not be present, at least not with the current behavior. In my opinion the dialog window should be re-thought. Note that the dialog window can remain as-is for the following cases: 1. Several documents that already have a filename, but with unsaved changes. 2. Same as 1, but with an Unsaved Document. With only one Unsaved Document, the user normally better knows what is the content of the Unsaved Document, so he/she can choose more easily a good filename. There is anyway the "Cancel" button so it's also possible to come back to the Unsaved Document, scroll its content and then save it manually.
> Note that the dialog window can remain as-is for the following cases: I'm not sure about the point 2. I guess it'll be clearer with a working implementation, so we can test and see if it's logical. What is also possible is to save and/or close all the other tabs, so only the Unsaved Documents remain open to manually save them. If there are 30 tabs with only 2 Unsaved Documents, finding them can take some time.
Created attachment 292752 [details] [review] Save changes before closing dialog
Review of attachment 292752 [details] [review]: It isn't just a matter of hiding the "save" button, a different dialog window (with a different message) is needed in my opinion.
If bug #745979 is fixed, this one is obsolete.
Mass-closing of all gedit bugzilla tickets. Special "code" to find again all those gedit bugzilla tickets that were open before the mass-closing: 2bfe1b0590a78457e1f1a6a90fb975f5878cb60064ccfe1d7db76ca0da52f0f3 By searching the above sha256sum in bugzilla, the gedit contributors can find again the tickets. We may be interested to do so when we work on a specific area of the code, to at least know the known problems and possible enhancements. We do this mass-closing because bugzilla.gnome.org is being replaced by gitlab.gnome.org.