After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741495 - tests/aggregator: Use correct type when setting property
tests/aggregator: Use correct type when setting property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-14 00:33 UTC by Sebastian Rasmussen
Modified: 2014-12-14 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1008 bytes, patch)
2014-12-14 00:33 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-12-14 00:33:20 UTC 
According to gst_aggregator_class_init() the property "timeout" is declared as an int64, yet the unittest still tries to set it as an int:

g_object_set (agg, "timeout", 1000 /* 1 us */ , NULL);

Instead the literal 1000 ought to be cast to a 64-bit type. The attached patch fixes this, and the unittests still run successfully.
Comment 1 Sebastian Rasmussen 2014-12-14 00:33:58 UTC 
Created attachment 292680 [details] [review]
Proposed patch.
Comment 2 Sebastian Rasmussen 2014-12-14 00:35:30 UTC 
this was meant to be raised for gst-plugins-bad, not -base. can you change that or at least apply the patch in the right place? :)
Comment 3 Sebastian Dröge (slomo) 2014-12-14 10:29:02 UTC 
commit 01dc7edd8bbaa1fb807202a59256390c3b786da5
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sun Dec 14 01:29:26 2014 +0100

    tests/aggregator: Use correct type when setting property
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=741495