After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741480 - Don't create streams for alternate screen
Don't create streams for alternate screen
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.39.x
Other Linux
: Normal enhancement
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-13 12:14 UTC by Egmont Koblinger
Modified: 2014-12-14 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix(?) (3.04 KB, patch)
2014-12-13 12:15 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2014-12-13 12:14:01 UTC 
To assert that bug 646098 comment 12 won't arise again, the best assertion would probably be not creating streams at all for the alternate screen's ring.

It'll also be important for bug 738601, since in its current state the stream immediately creates 3*64k buffers (read cache, write batching, and tmp for compression), multiplied by 3 streams is more than half a meg wasted for each vte. Although it could/should be achieved there as well with deferred initialization.
Comment 1 Egmont Koblinger 2014-12-13 12:15:00 UTC 
Created attachment 292659 [details] [review]
Fix(?)

A quickly created fix, still needs heavy testing.
Comment 2 Behdad Esfahbod 2014-12-14 00:16:51 UTC 
lgtm if it works!
Comment 3 Egmont Koblinger 2014-12-14 22:27:26 UTC 
Submitted (slightly modified).