After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741436 - Missing ellipses on the preferences dialog
Missing ellipses on the preferences dialog
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-12 11:26 UTC by Michael Catanzaro
Modified: 2015-02-03 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Missing ellipses on the preferences dialog (2.12 KB, patch)
2014-12-12 11:26 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-12-12 11:26:08 UTC 
When button labels are verbs and the button opens a dialog, the label should end with an ellipses.
Comment 1 Michael Catanzaro 2014-12-12 11:26:11 UTC 
Created attachment 292606 [details] [review]
Missing ellipses on the preferences dialog

mcatanzaro: aday: Hey! When you have a menu item that opens a dialog you
have to use ellipses to indicate that further input will be required.
Does that rule also apply to text buttons that open dialogs?01:52:47 PM
aday: mcatanzaro: yep01:54:05 PM
aday: the label has to be an action though01:54:28 PM
aday: Print...01:54:34 PM
aday: Open...01:54:36 PM
aday: i saw Properties... the other day01:54:46 PM
aday: that's wrong01:54:49 PM
Comment 2 Robert Roth 2015-01-05 19:21:18 UTC 
Review of attachment 292606 [details] [review]:

Looks fine, and these should be ellipsized indeed, based on Allan's comments and the HIG.
Comment 3 Michael Catanzaro 2015-02-03 20:28:41 UTC 
Attachment 292606 [details] pushed as b67a105 - Missing ellipses on the preferences dialog