After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741425 - debugutils: Add a gst_debug_bin_to_dot_data() method
debugutils: Add a gst_debug_bin_to_dot_data() method
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-12 07:47 UTC by Arun Raghavan
Modified: 2014-12-12 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
debugutils: Add a gst_debug_dump_dot_data() method (16.11 KB, patch)
2014-12-12 07:47 UTC, Arun Raghavan 		none Details | Review
Get the function name right. :/ (16.11 KB, patch)
2014-12-12 07:51 UTC, Arun Raghavan 		reviewed Details | Review
debugutils: Add a gst_debug_bin_to_dot_data() method (15.66 KB, patch)
2014-12-12 12:31 UTC, Arun Raghavan 		committed Details | Review

Description Arun Raghavan 2014-12-12 07:47:42 UTC 
This provides the dot file as a string, rather than dumping to a file.
Comment 1 Arun Raghavan 2014-12-12 07:47:47 UTC 
Created attachment 292590 [details] [review]
debugutils: Add a gst_debug_dump_dot_data() method
Comment 2 Arun Raghavan 2014-12-12 07:51:07 UTC 
Created attachment 292591 [details] [review]
Get the function name right. :/
Comment 3 Sebastian Dröge (slomo) 2014-12-12 09:16:19 UTC 
Review of attachment 292591 [details] [review]:

Looks good to me, but maybe it would be simpler to just always use the to_dot_data() method and write it to a file if needed afterwards?
Comment 4 Arun Raghavan 2014-12-12 09:30:34 UTC 
I separated the two paths as a bit of a premature micro-optimisation (so we don't allocate a bunch of potentially large string buffers for the write-to-file case).
Comment 5 Sebastian Dröge (slomo) 2014-12-12 10:05:40 UTC 
Yeah, I think it's ok as is but I'm a bit worried about maintainability and readability of that code and if it is really worth the potential trouble :)
Comment 6 Arun Raghavan 2014-12-12 12:31:08 UTC 
Created attachment 292609 [details] [review]
debugutils: Add a gst_debug_bin_to_dot_data() method

Fair enough, I see your point, simplified this now to always use the
string-building path.
Comment 7 Sebastian Dröge (slomo) 2014-12-12 12:42:47 UTC 
Review of attachment 292609 [details] [review]:

Looks good, thanks :)
Comment 8 Arun Raghavan 2014-12-12 12:48:09 UTC 
Thanks for the quick review :)