After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741392 - Allow to access the URL bar in application mode
Allow to access the URL bar in application mode
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Web Applications
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-11 11:34 UTC by Carlos Garcia Campos
Modified: 2015-04-25 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (2.35 KB, patch)
2014-12-11 11:35 UTC, Carlos Garcia Campos
committed Details | Review

Description Carlos Garcia Campos 2014-12-11 11:34:13 UTC
To easily copy the current URL, for example.
Comment 1 Carlos Garcia Campos 2014-12-11 11:35:12 UTC
Created attachment 292527 [details] [review]
Patch
Comment 2 Michael Catanzaro 2014-12-11 15:17:46 UTC
Review of attachment 292527 [details] [review]:

::: src/ephy-window.c
@@ +3467,3 @@
 	if (mode == EPHY_EMBED_SHELL_MODE_APPLICATION)
 	{
+		g_object_set(priv->location_controller, "editable", FALSE, NULL);

Missing space
Comment 3 Carlos Garcia Campos 2015-02-03 14:30:09 UTC
I've just pushed this to git master.
Comment 4 Carlos Garcia Campos 2015-02-03 14:30:34 UTC
(In reply to comment #2)
> Review of attachment 292527 [details] [review]:
> 
> ::: src/ephy-window.c
> @@ +3467,3 @@
>      if (mode == EPHY_EMBED_SHELL_MODE_APPLICATION)
>      {
> +        g_object_set(priv->location_controller, "editable", FALSE, NULL);
> 
> Missing space

Oh, I forgot to address this, sorry, not a big deal anyway.
Comment 5 Duke 2015-04-25 18:53:27 UTC
Maybe this commit isn't a good move for the project, I'm trying epiphany now because this app mode, and my surprise when I see the "app" looks like a web browser :/  or like web popup. 

The Android[1] and iPhone[2] has the same feature and Android hide location and toolbar by default and iPhone use a meta tag to hide or not the location and toolbar


[1]: https://developer.chrome.com/multidevice/android/installtohomescreen

[2]: https://developer.apple.com/library/ios/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html#//apple_ref/doc/uid/TP40002051-CH3-SW2