After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741385 - URLs sometimes saved into history in place of page titles
URLs sometimes saved into history in place of page titles
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: History
3.14.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-11 10:47 UTC by Michael Catanzaro
Modified: 2015-09-08 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't overwrite page titles in history (2.03 KB, patch)
2015-07-25 20:08 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-12-11 10:47:33 UTC 
Sometimes, the URL of a page is saved into history as the title of the page. It will show up in the history dialog and location entry completion with the URL listed twice, which looks quite poor. Haven't figured out the conditions that cause this to occur.
Comment 1 Michael Catanzaro 2015-07-25 20:08:51 UTC 
Created attachment 308149 [details] [review]
Don't overwrite page titles in history

When loading a page, we schedule two history updates: the first to reset
the page's title to the empty string (when the web view's title property
is unset after load started) and the second to set the page's title
properly. The first history update is obviously a mistake. It seems like
it should be harmless, so long as the page load is allowed to complete,
but avoiding it seems to solve the bug where pages appear in the history
dialog with URLs for the title, and it's clearly wrong, so let's stop
doing this.
Comment 2 Michael Catanzaro 2015-08-30 14:00:50 UTC 
Pinging reviewers
Comment 3 Michael Catanzaro 2015-09-08 16:54:55 UTC 
r+ from Claudio
Comment 4 Michael Catanzaro 2015-09-08 17:40:09 UTC 
Attachment 308149 [details] pushed as 257ecd1 - Don't overwrite page titles in history