GNOME Bugzilla – Bug 741314
[regression] No border / shadow underneath items dragged onto listviews, treeviews and Nautilus' sidebar
Last modified: 2014-12-12 04:23:01 UTC
When you drag a mail into a different folder in Evolution, or a file into Nautilus' sidebar, you don't get a shadow/border of the target anymore, which makes it very hard to "aim". I know from experience (with various users whose computers I maintain) that this was a significant usability issue in GNOME 3.0 that was fixed sometime around 3.2 or 3.4 (IIRC). With 3.14, we're back to the same problem.
Oh, and this feature used to cover both inserting "onto" and "inbetween" items in a list.
I see drop target highlighting work, in both tree views (try tests/testtreeview, a black line is drawn), and in the places sidebar (whenever a drop is possible, we show a 'New bookmark' placeholder)
Created attachment 292508 [details] [review] Adwaita: Draw drag highlight around treeview rows This got lost somewhere.
I guess you were missing the frame around the row for dropping into. We lost that somewhere along the way. The black line that I mentioned above is the indication for dropping between rows, and that was still working.
Attachment 292508 [details] pushed as 17be8c3 - Adwaita: Draw drag highlight around treeview rows
Ah yes. I see that in Liferea, the "inbetween rows" treeview drag indication works. Quick check: from a purely theoretical perspective I looked at your patch and it seems that you set "1px solid black" for both gtk-contained.css and gtk-contained-dark.css. Shouldn't it be "1px solid white" for gtk-contained-dark.css ?