GNOME Bugzilla – Bug 741255
Search engine preferences not migrated when URLs change
Last modified: 2014-12-08 18:56:28 UTC
1. Start epiphany with the default settings 2. Change search engine to Google 3. Upgrade to a version of Epiphany with a different search URL for Google (such as 4b80445233471e4fd9f92b59fcf0e213e4d631bf, or log in under a different locale with its own Google version) 4. Realise that the search URL isn't updated And it showed "http://google.com/search?q=%s" as the search engine. Instead the search engine preferences should be an enum, which would follow the stock versions, and the translations (so logging in to a fr_FR desktop would actually switch the Google version to google.fr for example), and offer a fourth engine in the schemas "custom" which would be whatever the user configured. This would avoid naked URLs showing up in the "Seach engine" drop-down, and avoid breakage like search not working anymore when Google started redirecting HTTP traffic to HTTPS.
Created attachment 292309 [details] [review] prefs-dialog: Make sure locale changes do not lose search engine Add a stock unstranslatable url to be stored in gsettings so that locale changes do not confuse the settings dialog.
Review of attachment 292309 [details] [review]: ::: src/prefs-dialog.c @@ +1111,2 @@ gtk_tree_model_get (GTK_TREE_MODEL (store), &iter, + SEARCH_ENGINE_COL_STOCK_URL, &stock_url, You are leaking this.
Fixed that and pushed.