After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741254 - Improper headers guards
Improper headers guards
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-12-08 13:58 UTC by Morten Welinder
Modified: 2014-12-09 00:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2014-12-08 13:58:14 UTC 
Files

    gtk/gtkplacessidebar.h
    gdk/gdkenumtypes.h
    gdk/gdkframetimings.h
    gdk/gdkframeclock.h

are improperly guarded.  The problem is that the guard should cover everything,
including the test for being included outside gtk.  Failing to do that, makes
gcc miss the optimization of not including the file the second time.


File gtk/xembed.h isn't guarded at all.  Might be deliberate.

Files

    gdk/x11/gdkeventsource.h
    gdk/broadway/gdkeventsource.h

have same guard.