After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741236 - Don't set "titlebar" class when using headerbar widget as a toolbar
Don't set "titlebar" class when using headerbar widget as a toolbar
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-08 08:18 UTC by darkxst
Modified: 2014-12-08 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't set "titlebar" class when using headerbar widget as a toolbar (1.10 KB, patch)
2014-12-08 08:18 UTC, darkxst 		none Details | Review
Don't set "titlebar" class when using headerbar widget as a toolbar (1.00 KB, patch)
2014-12-08 09:29 UTC, darkxst 		committed Details | Review

Description darkxst 2014-12-08 08:18:03 UTC 
It doesn't really make sense in the headerbar as toolbar case, and is causing some theming issues on ubuntu themes.
Comment 1 darkxst 2014-12-08 08:18:05 UTC 
Created attachment 292285 [details] [review]
Don't set "titlebar" class when using headerbar widget as a toolbar
Comment 2 Lars Karlitski 2014-12-08 08:21:54 UTC 
Review of attachment 292285 [details] [review]:

::: src/interface.cpp
@@ +648,3 @@
         headerbar = GTK_WIDGET (gtk_builder_get_object (builder, "header_bar"));
+        gtk_style_context_remove_class (gtk_widget_get_style_context (headerbar), "titlebar");
+        gtk_style_context_add_class (gtk_widget_get_style_context (headerbar), "header-bar");

There's no need to set .header-bar here, because GtkHeaderBar already sets that on itself.
Comment 3 darkxst 2014-12-08 09:29:00 UTC 
Created attachment 292291 [details] [review]
Don't set "titlebar" class when using headerbar widget as a toolbar

updated for lars' comment
Comment 4 Robert Roth 2014-12-08 20:16:33 UTC 
Thanks for the patch.
Attachment 292291 [details] pushed as 1d7839b - Don't set "titlebar" class when using headerbar widget as a toolbar