After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741231 - glfilter: position/texcoord attrib index usage
glfilter: position/texcoord attrib index usage
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-08 03:17 UTC by comicfans44
Modified: 2014-12-11 08:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
misc patch to fix position/texcoord attribute index usage (2.06 KB, patch)
2014-12-08 03:17 UTC, comicfans44 		committed Details | Review

Description comicfans44 2014-12-08 03:17:47 UTC 
Created attachment 292278 [details] [review]
misc patch to fix position/texcoord attribute index usage

gstglfilter _bind_buffer (line 1522) call VertexAttribPointer before get the 
attrib location, so 

  _get_attributes (filter);

should be called before

   gl->VertexAttribPointer (filter->draw_attr_position_loc, 3, GL_FLOAT,
       GL_FALSE, 5 * sizeof (GLfloat), (void *) 0);
?
plus, 0 is valid vertex attrib index(-1 is invalid) ,so we should init 
attrib index to -1, and compare with -1 ? if so , this patch fix this.
Comment 1 Matthew Waters (ystreet00) 2014-12-11 08:34:08 UTC 
Thanks!

commit 88909636fedbc7204506d058945661a25b308617
Author: Wang Xin-yu (王昕宇) <comicfans44@gmail.com>
Date:   Mon Dec 8 11:02:51 2014 +0800

    glfilter: fix position/texcoord attrib index usage
    
    https://bugzilla.gnome.org/show_bug.cgi?id=741231