After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741223 - Never override CFLAGS in a makefile
Never override CFLAGS in a makefile
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-07 18:51 UTC by Michael Catanzaro
Modified: 2014-12-09 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Never override CFLAGS in a makefile (848 bytes, patch)
2014-12-07 18:51 UTC, Michael Catanzaro 		committed Details | Review
Don't set AM_CFLAGS in configure.ac (3.05 KB, patch)
2014-12-07 19:15 UTC, Michael Catanzaro 		none Details | Review
Don't set AM_CFLAGS in configure.ac (3.05 KB, patch)
2014-12-07 19:21 UTC, Michael Catanzaro 		accepted-commit_now Details | Review

Description Michael Catanzaro 2014-12-07 18:51:29 UTC 
This prevents the user from setting his own desired CFLAGS
Comment 1 Michael Catanzaro 2014-12-07 18:51:31 UTC 
Created attachment 292255 [details] [review]
Never override CFLAGS in a makefile

This prevents the user from specifying his own desired CFLAGS.
Comment 2 Michael Catanzaro 2014-12-07 19:15:25 UTC 
Created attachment 292259 [details] [review]
Don't set AM_CFLAGS in configure.ac

This makes it impossible to use AM_CFLAGS, a useful variable, without
manually overwriting the value given in configure.ac. Instead, just
add WARN_CFLAGS to AM_CFLAGS everywhere.

Also, stop setting several other variables with empty values.
Comment 3 Michael Catanzaro 2014-12-07 19:21:41 UTC 
Created attachment 292260 [details] [review]
Don't set AM_CFLAGS in configure.ac

This makes it impossible to use AM_CFLAGS, a useful variable, without
manually overwriting the value given in configure.ac. Instead, just
add WARN_CFLAGS to AM_CFLAGS everywhere.

Also, stop setting several other variables with empty values.
Comment 4 Claudio Saavedra 2014-12-07 19:33:05 UTC 
Review of attachment 292255 [details] [review]:

Looks better.
Comment 5 Claudio Saavedra 2014-12-07 19:34:08 UTC 
Review of attachment 292260 [details] [review]:

I would probably remove the empty valued variables in a separate patch, if you don't mind.