After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741219 - pixbuf dependency
pixbuf dependency
Status: RESOLVED FIXED
Product: gom
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gom Maintainers
Gom Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-07 15:12 UTC by Patrick Welche
Modified: 2014-12-09 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build patch (1.31 KB, patch)
2014-12-08 23:29 UTC, Patrick Welche 		accepted-commit_now Details | Review

Description Patrick Welche 2014-12-07 15:12:55 UTC 
It seems that pixbuf is only necessary for tests, yet the PKG_CHECK_MODULES check for pixbuf makes it a hard dependency (whether or not gtester is available - might be worth an --enable-tests flag, on by default).
Comment 1 Bastien Nocera 2014-12-07 16:58:19 UTC 
Given that gdk-pixbuf is already part of the stack, it's not a problem for me or other people hacking on gom. I'd take a patch to make tests optional, or switch from GdkPixbuf's usage in the tests to something else that wouldn't introduce a new dependency.
Comment 2 Patrick Welche 2014-12-08 23:29:53 UTC 
Created attachment 292339 [details] [review]
build patch

I think this trivial patch does the trick. The key point is that the build doesn't bail if gdk-pixbuf isn't found (and glib already provides a --disable-glibtest)
Comment 3 Bastien Nocera 2014-12-09 00:19:38 UTC 
Review of attachment 292339 [details] [review]:

That looks fine, thanks
Comment 4 Patrick Welche 2014-12-09 08:25:17 UTC 
Committed - thanks!

https://git.gnome.org/browse/gom/commit/?id=34184c1e292d8d0c269d477ef9669a7da0127422