After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741200 - paint options spacing differs from brush spacing
paint options spacing differs from brush spacing
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2014-12-06 16:29 UTC by Hartmut Kuhse
Modified: 2015-01-11 22:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Inital patch that allows for interaction with brush saved values in preset friendly way (20.60 KB, patch)
2015-01-05 23:38 UTC, Alexia Death
needs-work Details | Review
Improved patch for linking (23.65 KB, patch)
2015-01-09 20:53 UTC, Alexia Death
needs-work Details | Review
Improved patch for linking vol 2 (19.87 KB, patch)
2015-01-10 19:17 UTC, Alexia Death
none Details | Review

Description Hartmut Kuhse 2014-12-06 16:29:15 UTC
I have a brushpipe with a spacing of 90%.
If I select that brush from the brushes dialog, the spacing is changed to the 90% value (shown in the lower of the brushes dialog).
The spacing in the paint options in the tool options dialog is not changed according to the spacing of the selected brush. Unfortunately, the spacing value in the paint options overrides the brush spacing, so that value must always be adjusted.
Comment 1 Michael Natterer 2014-12-13 23:45:13 UTC
This is an intentional change, but not complete. IMO There needs to be some
preference to configure that changing the brush should update the options,
or something like this. Always having the same brush options is just one
way of doing things, other people may prefer another ways.
Comment 2 Alexia Death 2015-01-04 18:34:39 UTC
One idea from top of my head is a master reset button that syncs all brush options in one click. Making it automatic is IMHO no-go, because it breaks presets usage...
Comment 3 Alexia Death 2015-01-04 22:30:48 UTC
And now that I have mulled it over, I have an idea, Id like to try that would mesh with presets just fine...
Comment 4 Alexia Death 2015-01-05 23:38:01 UTC
Created attachment 293884 [details] [review]
Inital patch that allows for interaction with brush saved values in preset friendly way

This is inital idea and up for commentary. It's pretty big change code wise, tho Im pretty sure everthing is where it should be. Screen space is also a consideration. Idealy, instead of two buttons, I think a long press concept that locks the reset buttion down for linking would make sense in my opinion...
Comment 5 Alexia Death 2015-01-09 20:53:07 UTC
Created attachment 294181 [details] [review]
Improved patch for linking

The patch reworks some internal workings, does a lot of renaming and adds sync between tools for linking status. Known issue - toggle buttons do not follow that sync...
Comment 6 Alexia Death 2015-01-10 19:17:50 UTC
Created attachment 294239 [details] [review]
Improved patch for linking vol 2

Another iteration of the patch. fixes buttons staying in sync with actual values and some whitespace.
Comment 7 Michael Natterer 2015-01-11 22:21:35 UTC
Fixed in master:

commit b0dbb2edf28fba18d53e019ac59eada1bf98ccb4
Author: Alexia Death <alexiadeath@gmail.com>
Date:   Tue Jan 6 01:30:35 2015 +0200

    Bug 741200 - paint options spacing differs from brush spacing
    
    Add "link" buttons to the tool options that are duplicates of brush
    properties, so the tool options values can be set to change along with
    the current brush.

 app/paint/gimppaintoptions.c     | 198 ++++++++++++++++++++++++++++++++-------
 app/paint/gimppaintoptions.h     |   6 ++
 app/tools/gimppaintoptions-gui.c | 132 ++++++++++++++++----------
 3 files changed, 255 insertions(+), 81 deletions(-)