After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741184 - [PATCH] applet: hardcode AP strength icons to 24x24
[PATCH] applet: hardcode AP strength icons to 24x24
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-12-05 23:00 UTC by Dan Williams
Modified: 2015-01-12 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-applet-hardcode-AP-strength-icons-to-24x24.patch (1.98 KB, patch)
2014-12-05 23:00 UTC, Dan Williams 		none Details | Review
before.png (29.31 KB, image/png)
2014-12-05 23:00 UTC, Dan Williams 		  Details
after.png (31.50 KB, image/png)
2014-12-05 23:00 UTC, Dan Williams 		  Details

Description Dan Williams 2014-12-05 23:00:07 UTC 
Created attachment 292217 [details] [review]
0001-applet-hardcode-AP-strength-icons-to-24x24.patch

The icon size in the menu is currently the same as the size of the
status icon.  That means if the status icon size is larger than
24x24 the menu looks awful.

We should be using GTK_ICON_SIZE_MENU here, but that's actually
a bit too small.  Since GTK hardcodes GTK_ICON_SIZE_MENU to 16x16
anyway, we might as well hardcode the size we want to use too.
Comment 1 Dan Williams 2014-12-05 23:00:36 UTC 
Created attachment 292218 [details]
before.png
Comment 2 Dan Williams 2014-12-05 23:00:56 UTC 
Created attachment 292219 [details]
after.png
Comment 3 Thomas Haller 2014-12-09 15:32:50 UTC 
LGTM
Comment 4 Jiri Klimes 2014-12-11 09:07:10 UTC 
The patch seems fine to me.
Comment 5 Dan Williams 2014-12-11 15:24:23 UTC 
Pushed as 5814648e6e3a7e825d85e1955736ffa284af541a
Comment 6 Pavel Simerda 2014-12-11 16:41:47 UTC 
Ho will that play with the appindicator patches which don't assume any particular icon size?