After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741179 - Export does not remember compression of input for Deflated TIFF
Export does not remember compression of input for Deflated TIFF
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.8.10
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
: 734656 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-12-05 20:49 UTC by Robert Prins
Modified: 2017-11-07 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.30 KB, patch)
2014-12-06 07:53 UTC, Massimo 		none Details | Review
proposed patch (1.65 KB, patch)
2014-12-07 18:27 UTC, Massimo 		accepted-commit_now Details | Review

Description Robert Prins 2014-12-05 20:49:18 UTC 
When editing a deflated TIFF image, a subsequent save (Ctrl-Shift-E) followed by Export and a confirmation of the Replace will show the compression as "None", requiring additional manual action to select "Deflate".
Comment 1 Michael Schumacher 2014-12-05 22:47:29 UTC 
Save (As) is Ctrl+(Shift+)s. 

Did your remap your shortcuts, or is the save in the description actually an export?
Comment 2 Robert Prins 2014-12-05 23:17:48 UTC 
It's an export. Other than defining CTRL-ALT-SHIFT-@, I haven't changed a single shortcut. And yes, it is an export.
Comment 3 Massimo 2014-12-06 07:53:24 UTC 
Created attachment 292228 [details] [review]
patch

Here, it is necessary something similar to:

https://git.gnome.org/browse/gimp/commit/plug-ins/common/file-tiff-save.c?h=gimp-2-8&id=91738c3b93f456a420334380bd0864a48e8dd0d3

for file-tiff-load.c.

In the attached patch I decided to treat COMPRESSION_DEFLATE as
COMPRESSION_ADOBE_DEFLATE, but perhaps you prefer to default to
COMPRESION_NONE.
Comment 4 Michael Natterer 2014-12-06 18:06:23 UTC 
Please push at will, I have no clue what you are doing there :)
Comment 5 Massimo 2014-12-07 18:27:08 UTC 
Created attachment 292254 [details] [review]
proposed patch

The problem is that there are 2 different compression tags
for the same compression method, libtiff accepts both and
GIMP GUI shows only one.

With the attached patch File->Overwrite preserves the tag
that is in the original tif, File->Export as... initializes
the GUI to the only one it knows when one of them is in the
original tif.

If there is no objection, I'll push this patch.
Comment 6 Massimo 2014-12-09 17:21:30 UTC 
fixed in master and gimp-2-8

commit 948e7a209dce3adfb574f44cd9b8a39a6d2fc08f
Author: Massimo Valentini <mvalentini@src.gnome.org>
Date:   Tue Dec 9 18:13:35 2014 +0100

    Bug 741179: Export does not remember compression of input...
    
    for Deflated TIFF
    
    similar to commit 91738c3b9
    
    (cherry picked from commit 068745dc5c968948ef0d10483a72aa207ae5ddf3)
Comment 7 Michael Schumacher 2017-11-07 14:08:02 UTC 
*** Bug 734656 has been marked as a duplicate of this bug. ***