After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741166 - Regression in 3.14.2: window is always opened with --no-default-window option
Regression in 3.14.2: window is always opened with --no-default-window option
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.14.x
Other Linux
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-05 15:01 UTC by Balló György
Modified: 2014-12-06 23:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
nautilus-application: Parse force-desktop before exiting (1.64 KB, patch)
2014-12-05 17:17 UTC, Carlos Soriano
committed Details | Review

Description Balló György 2014-12-05 15:01:48 UTC
Since the last update from version 3.14.1 to 3.14.2, Nautilus window is always opened if it started with the following command:

$ nautilus --no-default-window --force-desktop

This is a major problem, since nautilus-classic.desktop calls this command to start only the desktop in GNOME Classic on startup.

Probably caused by this commit:
https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-14&id=a5d9bc265fea325a10bf01c7743ee8ee246cee8c
Comment 1 Carlos Soriano 2014-12-05 17:17:08 UTC
Created attachment 292205 [details] [review]
nautilus-application: Parse force-desktop before exiting

In commit ae4d4960 we introduced a regression that a new window was
openned if both --no-default-window and --force-desktop options were
used.

To avoid that, activate those options before actually skipping the
activate of the application if --no-default-window option is provided.

The application nornally would exit if --no-default-window is provided
and the show-desktop-window is not activated, but, we rely on a the
detail that activating the open-desktop action when --force-desktop is
provided as a option, creates a new window, which makes the application
keep alive.
Comment 2 Ray Strode [halfline] 2014-12-05 17:20:29 UTC
Review of attachment 292205 [details] [review]:

looks good
Comment 3 Carlos Soriano 2014-12-05 19:09:20 UTC
Thanks for help Ray, hope now is finally fixed!

Attachment 292205 [details] pushed as 7f1ecc5 - nautilus-application: Parse force-desktop before exiting
Comment 4 Balló György 2014-12-05 19:18:33 UTC
Could you please also commit this to the gnome-3-14 branch?
Comment 5 Cosimo Cecchi 2014-12-06 23:10:08 UTC
I pushed this to gnome-3-14 too now.