After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741159 - hlssink: Add support for PROGRAM-DATE-TIME on playlist creation
hlssink: Add support for PROGRAM-DATE-TIME on playlist creation
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-05 12:50 UTC by Flávio Ribeiro
Modified: 2018-11-03 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
hlssink: add support for PROGRAM-DATE-TIME tag (3.32 KB, patch)
2014-12-05 12:54 UTC, Flávio Ribeiro 		none Details | Review
hlssink: add PROGRAM-DATE-TIME tag when chunk has discontinuity (3.32 KB, patch)
2014-12-11 20:03 UTC, Flávio Ribeiro 		none Details | Review

Description Flávio Ribeiro 2014-12-05 12:50:41 UTC 
There's some player implementations that take into account the PROGRAM-DATE-TIME to synchronize timestamps and sequence number when switching levels.
Comment 1 Flávio Ribeiro 2014-12-05 12:54:04 UTC 
Created attachment 292180 [details] [review]
hlssink: add support for PROGRAM-DATE-TIME tag

This patch adds support for PROGRAM-DATE-TIME tag on the playlist.
Comment 2 Flávio Ribeiro 2014-12-11 20:03:30 UTC 
Created attachment 292568 [details] [review]
hlssink: add PROGRAM-DATE-TIME tag when chunk has discontinuity

According to HLS spec 14, if a server provides PROGRAM-DATE-TIME on top of the playlist, it SHOULD also apply an EXT-X-PROGRAM-DATE-TIME tag to every segment that has an EXT-X-DISCONTINUITY tag applied to it.
Comment 3 Flávio Ribeiro 2014-12-11 20:05:53 UTC 
I'm wondering if it makes sense to isolate a function to add the program date time in a  given string in order to avoid duplications on gst_date_dime_get* calls introduced by those patches. What do you guys think?
Comment 4 Thiago Sousa Santos 2014-12-12 20:56:03 UTC 
(In reply to comment #3)
> I'm wondering if it makes sense to isolate a function to add the program date
> time in a  given string in order to avoid duplications on gst_date_dime_get*
> calls introduced by those patches. What do you guys think?

I think it makes sense, please do it. Either that or a macro.
Comment 5 GStreamer system administrator 2018-11-03 13:29:17 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/197.