After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741117 - Improve marks of GtkScale
Improve marks of GtkScale
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 741116 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-12-04 15:28 UTC by Carlos Soriano
Modified: 2014-12-05 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
widget-factory: Add a discontinuous GtkScale with marks (4.33 KB, patch)
2014-12-04 15:28 UTC, Carlos Soriano
reviewed Details | Review
gtkscale: Draw smaller marks (2.91 KB, patch)
2014-12-04 15:28 UTC, Carlos Soriano
committed Details | Review
widget-factory: Add a discontinuous GtkScale with marks (3.49 KB, patch)
2014-12-05 10:11 UTC, Carlos Soriano
committed Details | Review

Description Carlos Soriano 2014-12-04 15:28:34 UTC
referencing
Comment 1 Carlos Soriano 2014-12-04 15:28:36 UTC
Created attachment 292131 [details] [review]
widget-factory: Add a discontinuous GtkScale with marks

So designers can tweak the marks and developers can see how a
discontinuos scale is implemented.
Comment 2 Carlos Soriano 2014-12-04 15:28:41 UTC
Created attachment 292132 [details] [review]
gtkscale: Draw smaller marks

As a design request, use smaller marks.
Comment 3 Carlos Soriano 2014-12-04 15:31:03 UTC
(In reply to comment #0)
> referencing

Argh I messed up with the title.

Basically, improve the marks on GtkScale drawing them smaller as https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/nautilus/nautilus-menus.png and add one example on the widget factory for future referencing for designers and developers
Comment 4 Carlos Soriano 2014-12-04 15:32:02 UTC
Diference on widget factory
http://postimg.org/image/qnk2u5gat/

Nautilus with smaller marks
http://postimg.org/image/5w4iuvzul/full/
Comment 5 Matthias Clasen 2014-12-04 17:18:55 UTC
Review of attachment 292132 [details] [review]:

screenshot looked fine to me. as long we're using a fixed factor here, replacing /2 by /4 seems fine to me.
Comment 6 Matthias Clasen 2014-12-04 17:20:40 UTC
Review of attachment 292131 [details] [review]:

::: demos/widget-factory/widget-factory.c
@@ +1186,3 @@
+  for (i = (int)lower; i <= (int)upper; i++)
+    gtk_scale_add_mark (GTK_SCALE (widget), i, GTK_POS_BOTTOM, NULL);
+

I would prefer to add these in the .ui file:

<marks>
  <mark value="50" position="bottom"/>
  ...
</marks>
Comment 7 Matthias Clasen 2014-12-04 19:17:04 UTC
*** Bug 741116 has been marked as a duplicate of this bug. ***
Comment 8 Carlos Soriano 2014-12-05 10:11:57 UTC
Created attachment 292174 [details] [review]
widget-factory: Add a discontinuous GtkScale with marks

So designers can tweak the marks and developers can see how a
discontinuos scale is implemented.
Comment 9 Carlos Soriano 2014-12-05 10:13:01 UTC
(In reply to comment #6)
> Review of attachment 292131 [details] [review]:
> 
> ::: demos/widget-factory/widget-factory.c
> @@ +1186,3 @@
> +  for (i = (int)lower; i <= (int)upper; i++)
> +    gtk_scale_add_mark (GTK_SCALE (widget), i, GTK_POS_BOTTOM, NULL);
> +
> 
> I would prefer to add these in the .ui file:
> 
> <marks>
>   <mark value="50" position="bottom"/>
>   ...
> </marks>

didn't know I could do that, just found it on the docs now.
Comment 10 Matthias Clasen 2014-12-05 11:16:58 UTC
Review of attachment 292174 [details] [review]:

looks good, thanks
Comment 11 Jakub Steiner 2014-12-05 12:20:54 UTC
(In reply to comment #4)
> Diference on widget factory
> http://postimg.org/image/qnk2u5gat/
> 
> Nautilus with smaller marks
> http://postimg.org/image/5w4iuvzul/full/

Looks great.
Comment 12 Carlos Soriano 2014-12-05 12:24:09 UTC
Thanks for review!

Attachment 292132 [details] pushed as 0504328 - gtkscale: Draw smaller marks
Attachment 292174 [details] pushed as eec9a74 - widget-factory: Add a discontinuous GtkScale with marks