Created attachment 292131 [details] [review]
widget-factory: Add a discontinuous GtkScale with marks

So designers can tweak the marks and developers can see how a
discontinuos scale is implemented.

Created attachment 292132 [details] [review]
gtkscale: Draw smaller marks

As a design request, use smaller marks.

(In reply to comment #0)
> referencing

Argh I messed up with the title.

Basically, improve the marks on GtkScale drawing them smaller as https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/nautilus/nautilus-menus.png and add one example on the widget factory for future referencing for designers and developers

Diference on widget factory
http://postimg.org/image/qnk2u5gat/

Nautilus with smaller marks
http://postimg.org/image/5w4iuvzul/full/

Review of attachment 292132 [details] [review]:

screenshot looked fine to me. as long we're using a fixed factor here, replacing /2 by /4 seems fine to me.

Review of attachment 292131 [details] [review]:

::: demos/widget-factory/widget-factory.c
@@ +1186,3 @@
+  for (i = (int)lower; i <= (int)upper; i++)
+    gtk_scale_add_mark (GTK_SCALE (widget), i, GTK_POS_BOTTOM, NULL);
+

I would prefer to add these in the .ui file:

<marks>
  <mark value="50" position="bottom"/>
  ...
</marks>

*** Bug 741116 has been marked as a duplicate of this bug. ***

Created attachment 292174 [details] [review]
widget-factory: Add a discontinuous GtkScale with marks

So designers can tweak the marks and developers can see how a
discontinuos scale is implemented.

(In reply to comment #6)
> Review of attachment 292131 [details] [review]:
> 
> ::: demos/widget-factory/widget-factory.c
> @@ +1186,3 @@
> +  for (i = (int)lower; i <= (int)upper; i++)
> +    gtk_scale_add_mark (GTK_SCALE (widget), i, GTK_POS_BOTTOM, NULL);
> +
> 
> I would prefer to add these in the .ui file:
> 
> <marks>
>   <mark value="50" position="bottom"/>
>   ...
> </marks>

didn't know I could do that, just found it on the docs now.

Review of attachment 292174 [details] [review]:

looks good, thanks

(In reply to comment #4)
> Diference on widget factory
> http://postimg.org/image/qnk2u5gat/
> 
> Nautilus with smaller marks
> http://postimg.org/image/5w4iuvzul/full/

Looks great.

Thanks for review!

Attachment 292132 [details] pushed as 0504328 - gtkscale: Draw smaller marks
Attachment 292174 [details] pushed as eec9a74 - widget-factory: Add a discontinuous GtkScale with marks