Created attachment 292125 [details] [review]
shell-screenshot: Disable unredirection while taking screenshots

Otherwise we grab wrong contents.

Review of attachment 292125 [details] [review]:

Can you explain why exactly unredirection causes wrong contents to be taken?

::: src/shell-screenshot.c
@@ +179,3 @@
   g_assert (screenshot != NULL);
 
+

Extra whitespace.

(In reply to comment #2)
> Review of attachment 292125 [details] [review]:
> 
> Can you explain why exactly unredirection causes wrong contents to be taken?

Well you want to take a screenshot of the screen the unredirected window is not drawn on in the buffer we read from so you see what is beneath the window (kparal experienced this when trying to screenshot anaconda). In case of a window screenshot the texture is very old and thus wrong.

This patch as is is wrong anyway as pointed out by Owen on IRC (needs to do the redirection before queuing the frame).

Created attachment 292147 [details] [review]
shell-screenshot: Disable unredirection while taking screenshots

Otherwise we grab wrong contents.

---

Ok this one does the ununredirection (i.e redirection) before queuing the frame.

Created attachment 292148 [details] [review]
shell-screenshot: Disable unredirection while taking screenshots

Otherwise we grab wrong contents.

Pushed after IRC review.

Attachment 292148 [details] pushed as 76315fc - shell-screenshot: Disable unredirection while taking screenshots

Yesterday I was trying to get some screenshots from a fullscreen OpenGL game using a printscreen key, and I ended up with screenshots of the windows behind the game, or a white screen. Hopefully this will fix that. Thanks.