GNOME Bugzilla – Bug 741095
Refine volumes grid
Last modified: 2015-05-23 21:16:53 UTC
Created attachment 292109 [details] Screenshot 1 Overview: 1. Move css code to new resource file for easy to edit 2. Fix broken ui in Gnome 3.14 3. Color is changed for fit with theme color -> better for dark variant and custom themes
Created attachment 292110 [details] Screenshot 2 (Dark variant)
Created attachment 292111 [details] [review] Refine volumes grid
(In reply to comment #0) > 2. Fix broken ui in Gnome 3.14 It seems that the attached toolbar now has the correct styling. Is that what you mean by this point?
Created attachment 295528 [details] Screenshot Yes. But this patch also corrects volumes grid border style. You can see the problems in this screenshot.
(In reply to comment #4) > Created an attachment (id=295528) [details] > Screenshot > > Yes. But this patch also corrects volumes grid border style. You can see the > problems in this screenshot. Thanks, just checking! Looks good from a design point of view.
Review of attachment 292111 [details] [review]: Thanks for your patch! This definitely looks better than it did before. ::: src/disks/gduvolumegrid.c @@ +823,3 @@ + y + 1, + w - 2, + unused_height - 2); Can you explain where these numbers come from, please? It looks arbitrary to me. (Could this be handled in CSS instead?) ::: src/disks/gduwindow.c @@ +795,2 @@ provider = gtk_css_provider_new (); + file = g_file_new_for_uri ("resource:///org/gnome/Disks/ui/gdu.css"); Don't forget to use g_object_unref, or the GFile will be leaked.
Created attachment 300418 [details] [review] Refine volumes grid Thank you. Those numbers are used to avoid borders are effected by alpha color.
Review of attachment 300418 [details] [review]: Well I thought I delayed this patch because I had found something wrong with it and wanted to investigate more, but I forget what it was, and it looks fine, so I will push it. Thanks!
Attachment 300418 [details] pushed as 93195c1 - Refine volumes grid