After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741089 - Unused attributes in vapi files
Unused attributes in vapi files
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 741090 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-12-03 21:53 UTC by Vadim Rutkovsky
Modified: 2014-12-06 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vadim Rutkovsky 2014-12-03 21:53:14 UTC 
Some attributes are not used and fail the builds with latest vala:

 1. HasEmitter from gtk+-3.0.vapi, gio-2.0.vapi and webkitgtk-3.0.vapi
 2. ReturnsModifiedPointer from glib-2.0.vapi


See http://build.gnome.org/continuous/buildmaster/builds/2014/12/03/42/build/log-geary.txt
Comment 1 Jim Nelson 2014-12-03 21:54:57 UTC 
*** Bug 741090 has been marked as a duplicate of this bug. ***
Comment 2 Jim Nelson 2014-12-04 02:20:55 UTC 
I should add that I'm seeing this warning in California's own source code, where we use composite templates extensively.  It appears that every attribute in the code ([GtkChild], [GtkTemplate], [GtkCallback]) is being warned as never used.
Comment 3 Luca Bruno 2014-12-04 09:19:16 UTC 
Thanks for the feedback.

commit 2a7b848740cfe8eba6005803cf0167f54490c754
Author: Luca Bruno <lucabru@src.gnome.org>
Date:   Thu Dec 4 10:17:27 2014 +0100

    Add more used attributes
    
    Fixes bug 741089

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Jim Nelson 2014-12-04 20:56:43 UTC 
Thanks, Luca.  One more I found via Shotwell:

gio-unix-2.0.vapi:76.3-76.7: warning: argument `lower_case_prefix' never used
	[CCode (cheader_filename = "gio/gunixmounts.h", cname = "GUnixMountEntry", free_function = "g_unix_mount_free", lower_case_prefix = "g_unix_mount_")]
	 ^^^^^

And from California:

calendar/calendar-dbus.vala:19.2-19.5: warning: attribute `DBus' never used
[DBus (name = "org.freedesktop.timedate1")]
 ^^^^
Comment 5 Luca Bruno 2014-12-06 14:42:10 UTC 
The warning on lower_case_prefix is legit, it's not used.
Comment 6 Luca Bruno 2014-12-06 14:49:30 UTC 
commit c8dec345b6e2ad04ffcede24779dd75efd25d599
Author: Luca Bruno <lucabru@src.gnome.org>
Date:   Sat Dec 6 15:47:23 2014 +0100

    Add used DBus attribute and fix UnixMountEntry lower_case_cprefix
    
    Fixes bug 741089