After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741081 - data/grl-media-audio.c: Non-void function should return a value
data/grl-media-audio.c: Non-void function should return a value
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-12-03 18:04 UTC by Ting-Wei Lan
Modified: 2014-12-03 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "Non-void function should return a value" for clang (882 bytes, patch)
2014-12-03 18:06 UTC, Ting-Wei Lan 		accepted-commit_now Details | Review

Description Ting-Wei Lan 2014-12-03 18:04:16 UTC 
The function grl_media_audio_get_mb_artist_id uses g_return_if_fail, which should be changed to g_return_val_if_fail to prevent error.
Comment 1 Ting-Wei Lan 2014-12-03 18:06:10 UTC 
Created attachment 292088 [details] [review]
Fix "Non-void function should return a value" for clang
Comment 2 Bastien Nocera 2014-12-03 18:16:24 UTC 
Review of attachment 292088 [details] [review]:

Yep.