After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741058 - Avoid a harmless assignment to self, found by Coverity Scan
Avoid a harmless assignment to self, found by Coverity Scan
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: libgimp
git master
Other Linux
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2014-12-03 08:29 UTC by Murray Cumming
Modified: 2015-04-04 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-libgimpbase-Avoid-an-assignment-to-self.patch (1.12 KB, patch)
2014-12-03 08:29 UTC, Murray Cumming 		none Details | Review

Description Murray Cumming 2014-12-03 08:29:09 UTC 
Created attachment 292055 [details] [review]
0001-libgimpbase-Avoid-an-assignment-to-self.patch

This patch avoids a Coverity warning and seems to slightly improve the code anyway.
Comment 1 Jehan 2015-02-17 17:51:51 UTC 
Well this seems quite an obvious fix, so I took on me to validate and push the commit:

commit 58a557d8008fb4b5598fb9ce3be863dd3d21f3c7
Author: Murray Cumming <murrayc@murrayc.com>
Date:   Wed Dec 3 09:26:33 2014 +0100

    libgimpbase: Avoid an assignment to self.
    
    gimp_param_unit_value_validate() set a value to itself to not
    change the value, which was strange though not particularly wrong.
    Found by Coverity Scan.