After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741012 - should not override "all" target
should not override "all" target
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
Depends on:
Blocks:
 
 
Reported: 2014-12-02 10:52 UTC by Colin Walters
Modified: 2014-12-02 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Colin Walters 2014-12-02 10:52:50 UTC
I haven't tested this patch, but doing this is causing odd build failures in Continuous.

The "all" target is generated by automake, you should not be overriding its dependencies.  

What was this line trying to achieve?

Specifically the generated Makefile will have a dep on BUILT_SOURCES in all normally.

diff --git a/src/tracker-extract/Makefile.am b/src/tracker-extract/Makefile.am
index 92622bd..005241c 100644
--- a/src/tracker-extract/Makefile.am
+++ b/src/tracker-extract/Makefile.am
@@ -510,11 +510,6 @@ libextract_dummy_la_LIBADD = \
 	$(BUILD_LIBS) \
 	$(TRACKER_EXTRACT_MODULES_LIBS)
 
-#
-# Binaries
-#
-all: $(libexec_PROGRAMS) $(man_MANS)
-
 libexec_PROGRAMS = tracker-extract
 
 tracker_extract_SOURCES = \