GNOME Bugzilla – Bug 741006
Improve ConversationListView's cell rendering
Last modified: 2019-01-15 06:40:05 UTC
Created attachment 291957 [details] [review] proposed fix Actually, it seems that Geary's conversation preview bottom lines are 2px. This is a minor detail that somewhat affects the general impression of the app. Patch attached.
Nice catch. Thanks! Committed to master, commit ced85a
Under Ubuntu's ambiance theme, this makes the lines completely invisible. That's not necessarily a bad thing -- there's enough rhythm in the layout that it's obvious what goes with what.
Created attachment 292348 [details] [review] later fixup Please, apply this patch against Git master, test it and tell us the results.
No luck, I'm afraid. Upping the line width to 2.0 does result in a 1px-wide line, which is rather odd. We know that the Ambiance theme is buggy in other respects. I would not be surprised to learn that it has problems here as well.
This is actually really odd, because this part of the code is *not* theme dependent. I mean, the color and line width are both hardcoded. Maybe Ubuntu is using a buggy version of Cairo. Anyway, can we keep this bug marked as RESOLVED FIXED or should it be reopened?
I neglected to point out that the line appears correctly when using Adwaita, so it really is something in the Ambiance GTK+ theme that's triggering this, odd as it sounds. I might as well add that this is on Ubuntu 14.04. I have no strong feelings as to the state of the bug. If it sticks around long enough to make it to a release, we should reopen it or file a new one. Until then, I have no problems commenting on a closed issue. Maybe Jim feel differently?
I'm seeing this under Ambiance on 14.10 as well. Unfortunately, I'm going to have to back this out. The realities are such that Geary should more-or-less look the same between themes and desktops. Robert's correct, it's not *that* bad, but if we're going to adopt that aesthetic, it should be through design and not accident. The theme shouldn't matter, but apparently it does. If I change from Ambiance to Adwaita on 14.10, the lines reappear. I do note that they appear fainter/thinner under Ambiance. Why that is, I don't know. George, if you want to keep working on this, please do. Reverted in master, commit 1f0738
Actually, the patch seems to work well on both Adwaita and Ambiance on a fresh master build. Tested with Fedora 26, Ambiance unpacked from this package: http://mirrors.kernel.org/ubuntu/pool/main/u/ubuntu-themes/light-themes_16.10+17.10.20170703-0ubuntu1_all.deb and both patches from this bug.
Created attachment 355207 [details] Without the patches
Created attachment 355208 [details] With the patches
This is going to be fixed/obsoleted by the fix for Bug 730682, so adding a dep on that.
Resolving as obsolete all bugs that should be resolved by the conversation list redesign (https://bugzilla.gnome.org/show_bug.cgi?id=730682). I'd mark them as a duplicate, but bz won't let me :( Apologies for the noise.