GNOME Bugzilla – Bug 740974
Disable online accounts support
Last modified: 2015-03-25 13:50:47 UTC
I don't think that the same online accounts can be used to both PDFs/documents and books. So we should disable online accounts support for now, in gnome-books.
Created attachment 292801 [details] [review] books: Disable online accounts for now Until we can figure out which of the providers could be populating our view with ePubs or comics, just disable online accounts.
Created attachment 292802 [details] [review] books: Disable online accounts for now Until we can figure out which of the providers could be populating our view with ePubs or comics, just disable online accounts.
Review of attachment 292801 [details] [review]: It might be better to turn things off inside SourceManager (see src/search.js). We could also turn off the goaClient in src/application.js. ::: src/application.js @@ +396,2 @@ this._sourceAddedId = sourceManager.connect('item-added', Lang.bind(this, this._refreshMiners)); this._sourceRemovedId = sourceManager.connect('item-removed', Lang.bind(this, this._refreshMiners)); This is still going to start the miners if an account is added while the app is running, and will show the online sources in the search dropdown.
Review of attachment 292802 [details] [review]: Maybe turn off the Goa.Client.new_sync in src/application.js too?
Created attachment 292804 [details] [review] books: Disable online accounts for now Until we can figure out which of the providers could be populating our view with ePubs or comics, just disable online accounts.
Review of attachment 292804 [details] [review]: Perfect. Thanks for the patch, Bastien.
Created attachment 292839 [details] [review] books: Don't show "add online sources" without books If there are no books on the system, don't show the "Add online sources" link to gnome-control-center.
Review of attachment 292839 [details] [review]: Thanks for the patch, Bastien. Looks good to me. One minor nitpick. The subject sounds a bit confusing to me. Particularly the "without books" part. Maybe something like 'books: Don't show "add online source" when empty' ? Up to you.
Comment on attachment 292804 [details] [review] books: Disable online accounts for now Attachment 292804 [details] pushed as 0c68c18 - books: Disable online accounts for now
commit 8a35471a788a652fbc3a4eea881dbf66f504c09c Author: Bastien Nocera <hadess@hadess.net> Date: Tue Dec 16 16:08:12 2014 +0100 books: Don't show "add online sources" when empty If there are no books on the system, don't show the "Add online sources" link to gnome-control-center. https://bugzilla.gnome.org/show_bug.cgi?id=740974
Since we are disabling online accounts in gnome-books, we should also hide the 'share' button from the selection view because it only works for Google content at the moment. Reopening.
Created attachment 293087 [details] [review] selections: Hide "Share" button in Books As it only works with Google Docs, and that's disabled in gnome-books.
Review of attachment 293087 [details] [review]: Looks good to me.
Attachment 293087 [details] pushed as 5315cef - selections: Hide "Share" button in Books
Reassigning to new default assignee.