After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740953 - configure.ac: unportable test(1) comparison operator
configure.ac: unportable test(1) comparison operator
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-01 08:15 UTC by Thomas Klausner
Modified: 2014-12-12 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch addressing the issue. (580 bytes, patch)
2014-12-01 08:15 UTC, Thomas Klausner
committed Details | Review

Description Thomas Klausner 2014-12-01 08:15:54 UTC
Created attachment 291866 [details] [review]
Patch addressing the issue.

configure.ac uses the test(1) '==' comparison operator, which is only supported by bash's test(1), not even by the one coming with GNU coreutils. Please use '=' instead.
Comment 1 Sebastian Dröge (slomo) 2014-12-01 08:49:45 UTC
Thanks for the patch, but please attach patches in the future in "git format-patch" format :)

commit 655e6926bfbff216204fed2c33f0da2aeb89a942
Author: Thomas Klausner <wiz@danbala.tuwien.ac.at>
Date:   Mon Dec 1 09:48:41 2014 +0100

    configure: Do comparisons in a portable way with = instead of ==
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740953
Comment 2 Tim-Philipp Müller 2014-12-12 20:25:47 UTC
Cherry-picked into 1.4 branch.