After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740943 - core: Add register_keys plugin function
core: Add register_keys plugin function
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
: 739499 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-12-01 00:06 UTC by Bastien Nocera
Modified: 2015-01-27 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: Add register_keys plugin function (6.61 KB, patch)
2014-12-01 00:06 UTC, Bastien Nocera
none Details | Review
core: Add register_keys plugin function (12.00 KB, patch)
2014-12-01 15:40 UTC, Bastien Nocera
committed Details | Review
bookmarks: Use new register_keys vfunc (3.66 KB, patch)
2014-12-02 11:19 UTC, Bastien Nocera
committed Details | Review
gravatar: Use new register_keys vfunc (2.84 KB, patch)
2014-12-02 11:20 UTC, Bastien Nocera
committed Details | Review
thetvdb: Use new register_keys vfunc (2.13 KB, patch)
2014-12-02 11:20 UTC, Bastien Nocera
committed Details | Review
tmdb: Use new register_keys vfunc (2.01 KB, patch)
2014-12-02 11:20 UTC, Bastien Nocera
committed Details | Review
tracker: Use new register_keys vfunc (6.62 KB, patch)
2014-12-02 11:20 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2014-12-01 00:06:14 UTC
.
Comment 1 Bastien Nocera 2014-12-01 00:06:17 UTC
Created attachment 291852 [details] [review]
core: Add register_keys plugin function

This allows for custom metadata keys to be registered before the
plugins, or even the sources, are loaded.
Comment 2 Bastien Nocera 2014-12-01 00:07:10 UTC
This will require plugin changes as well, for which I have patches. I'll push those once this is decided.
Comment 3 Bastien Nocera 2014-12-01 15:40:14 UTC
Created attachment 291919 [details] [review]
core: Add register_keys plugin function

This allows for custom metadata keys to be registered before the
plugins, or even the sources, are loaded.
Comment 4 Bastien Nocera 2014-12-01 15:45:14 UTC
We needed to make some changes to the plugin loading so that the plugin was "prepared" (with module existing, vfuncs populated, etc.) before first, registering the keys for all the plugins, *then* init'ing each of the plugins.

This means that lua sources can use metadata keys from other plugins now.
Comment 5 Bastien Nocera 2014-12-02 11:19:59 UTC
Created attachment 291974 [details] [review]
bookmarks: Use new register_keys vfunc
Comment 6 Bastien Nocera 2014-12-02 11:20:05 UTC
Created attachment 291975 [details] [review]
gravatar: Use new register_keys vfunc
Comment 7 Bastien Nocera 2014-12-02 11:20:10 UTC
Created attachment 291976 [details] [review]
thetvdb: Use new register_keys vfunc
Comment 8 Bastien Nocera 2014-12-02 11:20:15 UTC
Created attachment 291977 [details] [review]
tmdb: Use new register_keys vfunc
Comment 9 Bastien Nocera 2014-12-02 11:20:20 UTC
Created attachment 291978 [details] [review]
tracker: Use new register_keys vfunc
Comment 10 Bastien Nocera 2014-12-02 15:02:36 UTC
*** Bug 739499 has been marked as a duplicate of this bug. ***
Comment 11 Bastien Nocera 2015-01-27 17:32:22 UTC
Comment on attachment 291919 [details] [review]
core: Add register_keys plugin function

Attachment 291919 [details] pushed as a4fac2b - core: Add register_keys plugin function
Comment 12 Bastien Nocera 2015-01-27 17:33:54 UTC
Attachment 291974 [details] pushed as 5e50ee2 - bookmarks: Use new register_keys vfunc
Attachment 291975 [details] pushed as 344d797 - gravatar: Use new register_keys vfunc
Attachment 291976 [details] pushed as af89bc4 - thetvdb: Use new register_keys vfunc
Attachment 291977 [details] pushed as 14ddadf - tmdb: Use new register_keys vfunc
Attachment 291978 [details] pushed as c92fb6d - tracker: Use new register_keys vfunc