After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740914 - Please respect allowMultipleSelection option in xkb data
Please respect allowMultipleSelection option in xkb data
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-30 07:25 UTC by Changwoo Ryu
Modified: 2016-04-14 18:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xkb: Support multiple selection options (4.04 KB, patch)
2016-04-13 21:17 UTC, Rui Matos
committed Details | Review
xkb: Use radio buttons for single selection options (3.84 KB, patch)
2016-04-14 18:46 UTC, Rui Matos
committed Details | Review
xkb: Sort options by their description (1.02 KB, patch)
2016-04-14 18:46 UTC, Rui Matos
committed Details | Review

Description Changwoo Ryu 2014-11-30 07:25:25 UTC
In the "Typing" section, XKB option settings are listed but all those options are assumed to be select-only-one style settings. But some XKB options have "allowMultipleSelection" tag so multiple choices could be selected.

For example in /usr/share/X11/xkb/rules/base.xml file,

    <group allowMultipleSelection="true">      
      <configItem>
        <name>grp</name>
        <description>Switching to another layout</description>
      </configItem>
Comment 1 Matthias Clasen 2016-04-12 16:39:19 UTC
Rui, this would be a nice bug to look at if you need a break from mutter - it would make the tweak tool xkb support much more useful.
Comment 2 Rui Matos 2016-04-13 21:17:25 UTC
Created attachment 325886 [details] [review]
xkb: Support multiple selection options

--

I hardcoded the list of options that allow multiple selection because
I don't want to add API to gnome-desktop at this point and this isn't
something that's going to change any time soon anyway. I'll include
this in a 3.20.1 resease.
Comment 3 Rui Matos 2016-04-13 21:18:38 UTC
Attachment 325886 [details] pushed as 7d1803f - xkb: Support multiple selection options
Comment 4 Matthias Clasen 2016-04-14 01:34:11 UTC
Thanks Rui!

I think the ui would be less confusing if the non-multi groups would still use radio buttons and added a 'Disabled' alternative.
Comment 5 Rui Matos 2016-04-14 18:46:35 UTC
Created attachment 326046 [details] [review]
xkb: Use radio buttons for single selection options
Comment 6 Rui Matos 2016-04-14 18:46:43 UTC
Created attachment 326047 [details] [review]
xkb: Sort options by their description
Comment 7 Rui Matos 2016-04-14 18:47:13 UTC
Attachment 326046 [details] pushed as 590931b - xkb: Use radio buttons for single selection options
Attachment 326047 [details] pushed as 72d6126 - xkb: Sort options by their description