After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740869 - facebook: Don't use the time as a fallback for the title
facebook: Don't use the time as a fallback for the title
Status: RESOLVED FIXED
Product: gnome-online-miners
Classification: Applications
Component: general
3.14.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Miners maintainer(s)
GNOME Online Miners maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-28 17:07 UTC by Debarshi Ray
Modified: 2014-12-01 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
facebook: Don't use the time as a fallback for the title (1.30 KB, patch)
2014-11-28 17:12 UTC, Debarshi Ray 		committed Details | Review
facebook: Remove stray debug message (887 bytes, patch)
2014-11-28 17:13 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-11-28 17:07:32 UTC 
The time is a ISO 8601 encoded string, and not human readable. So it is not a good choice as it is to be a fallback title. It is better to let the application handle it because there are cases where a fallback is useful and others where it is not. See bug 733214 and bug 733536
Comment 1 Debarshi Ray 2014-11-28 17:12:39 UTC 
Created attachment 291735 [details] [review]
facebook: Don't use the time as a fallback for the title
Comment 2 Debarshi Ray 2014-11-28 17:13:08 UTC 
Created attachment 291736 [details] [review]
facebook: Remove stray debug message
Comment 3 Álvaro Peña 2014-11-28 17:50:59 UTC 
Looks good to me, go ahead.
Comment 4 Debarshi Ray 2014-12-01 10:38:33 UTC 
Thanks for the review.