After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740864 - Symlink target for D-Bus service files includes DESTDIR
Symlink target for D-Bus service files includes DESTDIR
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
1.3.x
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
Depends on:
Blocks:
 
 
Reported: 2014-11-28 15:14 UTC by David King
Modified: 2014-12-02 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
change the symlink target to use the install root (3.93 KB, patch)
2014-11-28 15:16 UTC, David King 		committed Details | Review

Description David King 2014-11-28 15:14:57 UTC 
The change in 1.3.0 to merge all miner .desktop files into the D-Bus service files (ccbd489c79136388400f93af4f67f05516dc6a0e) used symlinks between the D-Bus service directory and the tracker miner directory. This is fine, but DESTDIR was used as the target of the link. Upon installation into DESTDIR, this is fine (as the symlink points to a file within DESTDIR), but upon installation of the DESTDIR tree into the real root, the symlink will dangle, as it still targets the DESTDIR location. The target of the symlink should be the target in the real root, not the DESTDIR root.
Comment 1 David King 2014-11-28 15:16:14 UTC 
Created attachment 291726 [details] [review]
change the symlink target to use the install root
Comment 2 Martyn Russell 2014-12-02 10:09:58 UTC 
Comment on attachment 291726 [details] [review]
change the symlink target to use the install root

Thanks for the patch, I see your point. I do wonder if this patch will cause problems for distros, but it looks right to me.
Comment 3 David King 2014-12-02 10:16:02 UTC 
Review of attachment 291726 [details] [review]:

Thanks! Pushed to master as e3f290872f3d1a7e40d37d54ba992a029d78fc33. This should improve the situation for distributions, as (at least) Fedora packaging tools fail to build a binary package if the symlinks point inside DESTDIR. I came up with this patch while preparing the 1.3.0 update for Fedora:

http://pkgs.fedoraproject.org/cgit/tracker.git/commit/?id=684e287eb8b1544a04b5c0fd5595eed7d94ed119