After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740853 - audiodecoder: Push pending events before sending EOS.
audiodecoder: Push pending events before sending EOS.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-28 14:08 UTC by Mathieu Duponchelle
Modified: 2014-12-12 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audiodecoder: Push pending events before sending EOS. (1.06 KB, patch)
2014-11-28 14:08 UTC, Mathieu Duponchelle 		none Details | Review
audiodecoder: Push pending events before sending EOS. (2.81 KB, patch)
2014-12-04 05:00 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2014-11-28 14:08:19 UTC 
Segments are added to the pending events, and pushing a segment
is mandatory before sending EOS.
Comment 1 Mathieu Duponchelle 2014-11-28 14:08:22 UTC 
Created attachment 291721 [details] [review]
audiodecoder: Push pending events before sending EOS.
Comment 2 Thiago Sousa Santos 2014-12-02 00:17:04 UTC 
Could you write a unit test to have added to our suite for audiodecoder? The same problem might also be happening in videodecoder. It would be good to check it there, too.
Comment 3 Mathieu Duponchelle 2014-12-04 05:00:47 UTC 
Created attachment 292115 [details] [review]
audiodecoder: Push pending events before sending EOS.

Segments are added to the pending events, and pushing a segment
is mandatory before sending EOS.

+ Adds a test.
Comment 4 Mathieu Duponchelle 2014-12-04 05:03:17 UTC 
Done, note that I already checked videodecoder and it pushes the segment event sequentially.

FWIW I think gst-validate now checks that a segment event is always sent before EOS.

Thanks for the review :)
Comment 5 Mathieu Duponchelle 2014-12-05 11:07:09 UTC 
commit b2413d46edb7c97d1ad4e2535dd5fe737b0c04bc
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Fri Nov 28 15:06:27 2014 +0100

    audiodecoder: Push pending events before sending EOS.
    
    Segments are added to the pending events, and pushing a segment
    is mandatory before sending EOS.
    
    + Adds a test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740853
Comment 6 Mathieu Duponchelle 2014-12-05 11:07:25 UTC 
Review of attachment 292115 [details] [review]:

commited
Comment 7 Tim-Philipp Müller 2014-12-12 16:05:20 UTC 
Cherry-picked into 1.4 branch.