After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740813 - [review] don't require UUID when adding connection [th/add-connection-uuid-bgo740813]
[review] don't require UUID when adding connection [th/add-connection-uuid-bg...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-27 16:26 UTC by Thomas Haller
Modified: 2014-12-05 10:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2014-11-27 16:26:03 UTC 
Up to now, DBUS API to add a connection would require the client to specify the connection UUID.

We can relax that requirement and generate one if it is missing.


Also I think it is wrong that the client is allowed to predetermine that UUID because he can provoke a collision. It would be better to always generate a new UUID when adding a connection. Is there a way to change that for 1.0?
Comment 1 Thomas Haller 2014-11-27 16:28:02 UTC 
branch: th/add-connection-uuid-bgo740813
Comment 2 Dan Winship 2014-12-01 11:12:04 UTC 
Makes sense to me, though I don't think you should land this one until we agree on bug 740865.
Comment 3 Dan Williams 2014-12-01 16:29:13 UTC 
> core: allow add connection without UUID set

"ourselfes" -> "ourselves" in the commit message.  Yay English.

But most of this will go away if we normalize the UUID as part of bug 740865 right?
Comment 4 Thomas Haller 2014-12-01 16:53:58 UTC 
(In reply to comment #3)
> > core: allow add connection without UUID set
> 
> "ourselfes" -> "ourselves" in the commit message.  Yay English.
> 
> But most of this will go away if we normalize the UUID as part of bug 740865
> right?

Right. If normalize() could add the UUID itself (bug 740865), the first patch would be obsolete. The second patch would become important.
Comment 5 Thomas Haller 2014-12-04 17:28:26 UTC 
Now that 740865 normalizes the connection, the patch became very simply.

Repushed.
Comment 6 Dan Williams 2014-12-05 01:05:30 UTC 
LGTM now