After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740802 - gdm package inconsistent regarding conflict with plymouth-quit.service
gdm package inconsistent regarding conflict with plymouth-quit.service
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-27 09:00 UTC by Gokul
Modified: 2014-12-19 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure: require plymouth if using systemd (3.34 KB, patch)
2014-12-05 17:35 UTC, Ray Strode [halfline]
committed Details | Review
Revert "configure: require plymouth if using systemd" (3.28 KB, patch)
2014-12-19 14:04 UTC, Ray Strode [halfline]
committed Details | Review
configure: require --without-plymouth to disable plymouth support (3.38 KB, patch)
2014-12-19 14:05 UTC, Ray Strode [halfline]
committed Details | Review
systemd: strip plymouth bits from unit file if built --without-plymouth (5.55 KB, patch)
2014-12-19 14:05 UTC, Ray Strode [halfline]
committed Details | Review

Description Gokul 2014-11-27 09:00:28 UTC
When gdm is compiled without "--with-plymouth" option, gdm.service should not conflict with plymouth-quit.service otherwise plymouth-quit service will not run and neither will gdm ask plymouth to quit.

Is it better to have --with-plymouth as the default for compiling gdm? Otherwise the conflict declaration in gdm.service should be tied to that same option.
Comment 1 Ray Strode [halfline] 2014-12-05 17:35:37 UTC
Created attachment 292209 [details] [review]
configure: require plymouth if using systemd

This is only a build requirement since gdm doesn't
link against plymouth or anything like that and will
work if it's not installed when run.
Comment 2 Ray Strode [halfline] 2014-12-05 17:35:54 UTC
Attachment 292209 [details] pushed as f8a21cd - configure: require plymouth if using systemd
Comment 3 Ray Strode [halfline] 2014-12-19 13:49:21 UTC
so my fix actually breaks some distros that don't ship plymouth but do ship systemd, reopening.
Comment 4 Ray Strode [halfline] 2014-12-19 14:04:58 UTC
Created attachment 293055 [details] [review]
Revert "configure: require plymouth if using systemd"

This reverts commit f8a21cd6cb2095e80889df8c41036e2df31ba01a.
Comment 5 Ray Strode [halfline] 2014-12-19 14:05:02 UTC
Created attachment 293056 [details] [review]
configure: require --without-plymouth to disable plymouth support

Plymouth is used pretty widely these days, and we're getting bugs
from people who didn't have the buildrequires, didn't get plymouth
support and were left with a broken setup.

Instead, just just let the distros that don't use plymouth opt out.
Comment 6 Ray Strode [halfline] 2014-12-19 14:05:05 UTC
Created attachment 293057 [details] [review]
systemd: strip plymouth bits from unit file if built --without-plymouth

Otherwise, if you have plymouth, but build --without-plymouth then boot
will screw up
Comment 7 Ray Strode [halfline] 2014-12-19 14:05:24 UTC
Attachment 293055 [details] pushed as a3ebb3e - Revert "configure: require plymouth if using systemd"
Attachment 293056 [details] pushed as 0950c62 - configure: require --without-plymouth to disable plymouth support
Attachment 293057 [details] pushed as 68259e0 - systemd: strip plymouth bits from unit file if built --without-plymouth