After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740761 - Correct "file size" metadata key
Correct "file size" metadata key
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-26 15:37 UTC by Bastien Nocera
Modified: 2014-11-27 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Add support for int64 values (6.80 KB, patch)
2014-11-26 15:37 UTC, Bastien Nocera 		committed Details | Review
core: Correct value type for file sizes (3.67 KB, patch)
2014-11-26 15:37 UTC, Bastien Nocera 		committed Details | Review
tracker: Fix filesize value type (2.04 KB, patch)
2014-11-26 15:39 UTC, Bastien Nocera 		committed Details | Review
lua-factory: Handle filesize types (975 bytes, patch)
2014-11-26 16:51 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-11-26 15:37:02 UTC 
.
Comment 1 Bastien Nocera 2014-11-26 15:37:05 UTC 
Created attachment 291563 [details] [review]
core: Add support for int64 values
Comment 2 Bastien Nocera 2014-11-26 15:37:12 UTC 
Created attachment 291564 [details] [review]
core: Correct value type for file sizes

An int is obviously too small a value to fit a filesize in bytes, with
its maximum at 2GB. Use an int64 instead.

Note, this breaks ABI but should not break API.
Comment 3 Bastien Nocera 2014-11-26 15:39:19 UTC 
Created attachment 291565 [details] [review]
tracker: Fix filesize value type

So that the value isn't truncated, or wrapped around for files > 2GB.

Bump requirement to grilo 0.2.12 so that the filesize type is corrected
as well.
Comment 4 Bastien Nocera 2014-11-26 16:51:28 UTC 
Created attachment 291571 [details] [review]
lua-factory: Handle filesize types
Comment 5 Bastien Nocera 2014-11-27 13:20:57 UTC 
Attachment 291563 [details] pushed as 6b26ee2 - core: Add support for int64 values
Attachment 291564 [details] pushed as 2e45b89 - core: Correct value type for file sizes
Comment 6 Bastien Nocera 2014-11-27 13:33:15 UTC 
Attachment 291565 [details] pushed as 256c154 - tracker: Fix filesize value type
Attachment 291571 [details] pushed as f4e90ca - lua-factory: Handle filesize types