GNOME Bugzilla – Bug 740726
track: [API]: ges_track_update_restriction_caps.
Last modified: 2015-06-24 14:42:55 UTC
+ And specify default restriction caps for audio and video tracks. + Add ges_track_set_restriction_caps to the sections, it was missing.
Created attachment 291515 [details] [review] track: [API]: ges_track_update_restriction_caps.
Review of attachment 291515 [details] [review]: Looks good in overall, but I really think we do not want to force caps for video, we will discuss that on IRC anyway. ::: ges/ges-track.c @@ +729,3 @@ } + Many spaces here ::: tests/check/ges/track.c @@ +1,2 @@ +/* GStreamer Editing Services + * Copyright (C) 2010 Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Back to the past? :)
Created attachment 291575 [details] [review] track: [API]: ges_track_update_restriction_caps. + And specify default restriction caps for audio and video tracks. + Add ges_track_set_restriction_caps to the sections, it was missing.
Created attachment 291576 [details] [review] track: [API]: ges_track_update_restriction_caps. + And specify default restriction caps for audio and video tracks. + Add ges_track_set_restriction_caps to the sections, it was missing.
Created attachment 291583 [details] [review] track: [API]: ges_track_update_restriction_caps. + And specify default restriction caps for audio tracks. + Add ges_track_set_restriction_caps to the sections, it was missing.
Review of attachment 291583 [details] [review]: Forgot to add the track.c file in the tests?
commit f85c463b9397903895aaa46a67f272a5948b8f7b Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Wed Nov 26 20:34:24 2014 +0100 track: [API]: ges_track_update_restriction_caps. + And specify default restriction caps for audio tracks. + Add ges_track_set_restriction_caps to the sections, it was missing. https://bugzilla.gnome.org/show_bug.cgi?id=740726 But I forgot to add the test before pushing, and I can't find it in my stashes anymore :( It passed is all I can say :)
commit d109c37343cbbc5a277f0bf9f942db251f23c780 Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Fri Dec 5 22:19:32 2014 +0100 check/ges/track: add forgotten test file.
Review of attachment 291583 [details] [review]: commited