GNOME Bugzilla – Bug 740696
Use local m4/ directory for macros
Last modified: 2017-04-13 23:44:11 UTC
Created attachment 291475 [details] Patch that fixes the problem Building GJS on JHBuild on OSX, ACLOCAL_FLAGS is set to "-I /my/jhbuild/tree/share/aclocal". GJS's Makefile.am sets ACLOCAL_AMFLAGS to ${ACLOCAL_FLAGS} which runs afoul during libtoolize. libtoolize --copy --force removes libtool macros from its macro directory before copying new ones. Thus it fails because it just removed the macros that it wanted to copy. This patch changes the build system to put macros in a local m4/ directory as most packages do. I don't think ACLOCAL_FLAGS needs to be passed specifically to ACLOCAL_AMFLAGS in order for aclocal to honor it.
Created attachment 291476 [details] [review] Patch with link to bugzilla bug Here's an updated patch with a link to this bug.
Review of attachment 291476 [details] [review]: Fine with me.
Committed to master, and I went ahead and committed it to the 3.14 branch as well, hope that's OK.