After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740696 - Use local m4/ directory for macros
Use local m4/ directory for macros
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Mac OS
: Normal critical
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-25 16:40 UTC by Philip Chimento
Modified: 2017-04-13 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes the problem (1.62 KB, application/octet-stream)
2014-11-25 16:40 UTC, Philip Chimento
  Details
Patch with link to bugzilla bug (1.67 KB, patch)
2014-11-25 16:41 UTC, Philip Chimento
committed Details | Review

Description Philip Chimento 2014-11-25 16:40:12 UTC
Created attachment 291475 [details]
Patch that fixes the problem

Building GJS on JHBuild on OSX, ACLOCAL_FLAGS is set to "-I /my/jhbuild/tree/share/aclocal". GJS's Makefile.am sets ACLOCAL_AMFLAGS to ${ACLOCAL_FLAGS} which runs afoul during libtoolize. libtoolize --copy --force removes libtool macros from its macro directory before copying new ones. Thus it fails because it just removed the macros that it wanted to copy.

This patch changes the build system to put macros in a local m4/ directory as most packages do. I don't think ACLOCAL_FLAGS needs to be passed specifically to ACLOCAL_AMFLAGS in order for aclocal to honor it.
Comment 1 Philip Chimento 2014-11-25 16:41:52 UTC
Created attachment 291476 [details] [review]
Patch with link to bugzilla bug

Here's an updated patch with a link to this bug.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-11-25 16:45:32 UTC
Review of attachment 291476 [details] [review]:

Fine with me.
Comment 3 Philip Chimento 2014-11-26 21:29:45 UTC
Committed to master, and I went ahead and committed it to the 3.14 branch as well, hope that's OK.