After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740685 - Do not expand tilde on Windows
Do not expand tilde on Windows
Status: RESOLVED FIXED
Product: libgovirt
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgovirt maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-25 13:36 UTC by Fabiano Fidêncio
Modified: 2014-11-26 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ovirt-options: Do not expand tilde on Windows (1.86 KB, patch)
2014-11-25 13:37 UTC, Fabiano Fidêncio 		committed Details | Review

Description Fabiano Fidêncio 2014-11-25 13:36:37 UTC 
As Windows doesn't have "~" (as the value of $HOME) the code used to expand tilde uses non-portable functions from pwd.h, what causes a break when building libgovirt using MinGW

Please, see the attached patch
Comment 1 Fabiano Fidêncio 2014-11-25 13:37:55 UTC 
Created attachment 291455 [details] [review]
ovirt-options: Do not expand tilde on Windows

As Windows doesn't have "~" (as the value of $HOME) the code used to
expand tilde uses non-portable functions from pwd.h, what causes a break
when building libgovirt using MinGW
Comment 2 Christophe Fergeau 2014-11-25 13:46:22 UTC 
Review of attachment 291455 [details] [review]:

::: govirt/ovirt-options.c
@@ +20,3 @@
 
+#include <glib.h>
+

Any particular reason for adding this include ?
Comment 3 Fabiano Fidêncio 2014-11-26 14:14:13 UTC 
Review of attachment 291455 [details] [review]:

::: govirt/ovirt-options.c
@@ +20,3 @@
 
+#include <glib.h>
+

G_OS_WIN32 is defined in glib.h, that's the reason of this include.
Would you like a comment like "Needed for G_OS_WIN32." right above the include?
Comment 4 Christophe Fergeau 2014-11-26 14:30:55 UTC 
Review of attachment 291455 [details] [review]:

::: govirt/ovirt-options.c
@@ +20,3 @@
 
+#include <glib.h>
+

Nope, no need for that, makes sense now, thanks ;)
Comment 5 Fabiano Fidêncio 2014-11-26 14:33:44 UTC 
Attachment 291455 [details] pushed as 41686bc - ovirt-options: Do not expand tilde on Windows