After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740680 - get rid of obsolete INCLUDES in Makefile.am
get rid of obsolete INCLUDES in Makefile.am
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-25 12:45 UTC by Pavel Simerda
Modified: 2014-11-27 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.87 KB, patch)
2014-11-25 12:45 UTC, Pavel Simerda 		none Details | Review

Description Pavel Simerda 2014-11-25 12:45:13 UTC 
Created attachment 291447 [details] [review]
patch

Get rid of obsolete INCLUDES in all makefiles and replace with *_CPPFLAGS.
Comment 1 Dan Winship 2014-11-25 13:41:49 UTC 
Yes. Only comment is

>+libnma_la_CPPFLAGS = ${AM_CPPFLAGS} $(MM_GLIB_CFLAGS)

We use $() everywhere else, so don't use ${} here
Comment 2 Thomas Haller 2014-11-25 14:13:28 UTC 
LGTM (assuming it compiles, which I didn't test :) )
Comment 3 Dan Williams 2014-11-26 19:36:27 UTC 
There was also a missing "\" at the end some lines.  Fixed that, the {}, and pushed.
Comment 4 Pavel Simerda 2014-11-27 12:04:25 UTC 
Thanks!