After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740667 - ../data/iagno-menus.ui: Error on line 3 char 1: Element <interface> not allowed at toplevel.
../data/iagno-menus.ui: Error on line 3 char 1: Element <interface> not allow...
Status: RESOLVED FIXED
Product: iagno
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: iagno-maint
iagno-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-25 00:58 UTC by Michael Catanzaro
Modified: 2014-11-29 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Revert “Fix distcheck” (937 bytes, patch)
2014-11-25 09:34 UTC, Arnaud B.
none Details | Review
Fix build (1.03 KB, patch)
2014-11-29 16:57 UTC, Michael Catanzaro
committed Details | Review
Proper fix for the previous commit (1.08 KB, patch)
2014-11-29 17:05 UTC, Michael Catanzaro
committed Details | Review
iagno-resources.c shouldn't be deleted by 'make clean' (847 bytes, patch)
2014-11-29 17:10 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-11-25 00:58:52 UTC
This build failure appears to be fallout from our use of gresource, but it can't be as I was able to successfully build and release iagno more recently than that. Something must have broken in a dependency:

  GEN      iagno-resources.c
../data/iagno-menus.ui: Error on line 3 char 1: Element <interface> not allowed at toplevel.


(Looks like it's trying to treat the menu file as a gresource specification?)
Comment 1 Arnaud B. 2014-11-25 09:34:22 UTC
Created attachment 291441 [details] [review]
Revert “Fix distcheck”

In my tree, I have this “Revert “Fix distckeck”” patch, and looks like it compile well. But I didn’t understood what the “Fix distcheck” patch was for…
Comment 2 Michael Catanzaro 2014-11-25 17:31:28 UTC
Comment on attachment 291441 [details] [review]
Revert “Fix distcheck”

That's to prevent this:

make[2]: Entering directory `/home/mcatanzaro/jhbuild/checkout/iagno/iagno-3.15.1/_build/src'
Makefile:629: warning: overriding recipe for target `../../src/computer-player.c'
Makefile:610: warning: ignoring old recipe for target `../../src/computer-player.c'
Makefile:634: warning: overriding recipe for target `../../src/game.c'
Makefile:615: warning: ignoring old recipe for target `../../src/game.c'
Makefile:649: warning: overriding recipe for target `../../src/player.c'
Makefile:620: warning: ignoring old recipe for target `../../src/player.c'
Failed to open file 'iagno.gresource.xml': No such file or directory
make[2]: *** No rule to make target `iagno.gresource.xml', needed by `iagno-resources.c'.  Stop

iagno.gresource.xml is not generated (e.g. from a hypothetical iagno.gresource.xml.in), so it doesn't make sense to list it as a build dependency.
Comment 3 Michael Catanzaro 2014-11-29 16:57:31 UTC
Not really sure why I need to list the dependency that already exists, but the file wasn't being distributed at all, that didn't help....

The following fix has been pushed:
bffbc08 Fix build
Comment 4 Michael Catanzaro 2014-11-29 16:57:34 UTC
Created attachment 291792 [details] [review]
Fix build
Comment 5 Michael Catanzaro 2014-11-29 17:05:35 UTC
Oh.

The following fix has been pushed:
7d1d334 Proper fix for the previous commit
Comment 6 Michael Catanzaro 2014-11-29 17:05:38 UTC
Created attachment 291793 [details] [review]
Proper fix for the previous commit
Comment 7 Michael Catanzaro 2014-11-29 17:10:44 UTC
The following fix has been pushed:
e2426e9 iagno-resources.c shouldn't be deleted by 'make clean'
Comment 8 Michael Catanzaro 2014-11-29 17:10:47 UTC
Created attachment 291794 [details] [review]
iagno-resources.c shouldn't be deleted by 'make clean'

It's distributed and not intended to be rebuilt.