After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740657 - filter: Support the GLOB operator from SQLite
filter: Support the GLOB operator from SQLite
Status: RESOLVED FIXED
Product: gom
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gom Maintainers
Gom Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-24 20:53 UTC by Mathieu Bridon
Modified: 2014-11-25 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
filter: Support the GLOB operator from SQLite (2.88 KB, patch)
2014-11-24 20:53 UTC, Mathieu Bridon
committed Details | Review
tests: Test behaviour of the GLOB operator (2.22 KB, patch)
2014-11-24 20:54 UTC, Mathieu Bridon
committed Details | Review
tests: Test behaviour of the GLOB operator (2.22 KB, patch)
2014-11-25 09:19 UTC, Mathieu Bridon
none Details | Review
filter: Support the GLOB operator from SQLite (2.88 KB, patch)
2014-11-25 09:19 UTC, Mathieu Bridon
none Details | Review

Description Mathieu Bridon 2014-11-24 20:53:50 UTC
http://www.sqlite.org/lang_expr.html#like
Comment 1 Mathieu Bridon 2014-11-24 20:53:54 UTC
Created attachment 291415 [details] [review]
filter: Support the GLOB operator from SQLite

http://www.sqlite.org/lang_expr.html#like
Comment 2 Mathieu Bridon 2014-11-24 20:54:04 UTC
Created attachment 291416 [details] [review]
tests: Test behaviour of the GLOB operator
Comment 3 Bastien Nocera 2014-11-25 01:01:11 UTC
Review of attachment 291415 [details] [review]:

Looks fine.
Comment 4 Bastien Nocera 2014-11-25 01:01:38 UTC
Review of attachment 291415 [details] [review]:

Looks fine.
Comment 5 Bastien Nocera 2014-11-25 01:01:45 UTC
Review of attachment 291415 [details] [review]:

Looks fine.
Comment 6 Bastien Nocera 2014-11-25 01:02:27 UTC
Review of attachment 291416 [details] [review]:

Looks good as well.
Comment 7 Mathieu Bridon 2014-11-25 09:19:50 UTC
The following fixes have been pushed:
d1f73ee tests: Test behaviour of the GLOB operator
40c70a0 filter: Support the GLOB operator from SQLite
Comment 8 Mathieu Bridon 2014-11-25 09:19:54 UTC
Created attachment 291439 [details] [review]
tests: Test behaviour of the GLOB operator
Comment 9 Mathieu Bridon 2014-11-25 09:19:59 UTC
Created attachment 291440 [details] [review]
filter: Support the GLOB operator from SQLite

http://www.sqlite.org/lang_expr.html#like
Comment 10 Mathieu Bridon 2014-11-25 09:23:00 UTC
Review of attachment 291415 [details] [review]:

Manually setting to committed, as it seems I used « git bz » wrong.
Comment 11 Mathieu Bridon 2014-11-25 09:23:25 UTC
Review of attachment 291416 [details] [review]:

Manually setting to committed as it seems I used « git bz » wrong.
Comment 12 Mathieu Bridon 2014-11-25 09:24:06 UTC
Comment on attachment 291415 [details] [review]
filter: Support the GLOB operator from SQLite

Removing obsolete, it seems I used « git bz » wrong.
Comment 13 Mathieu Bridon 2014-11-25 09:24:21 UTC
Comment on attachment 291416 [details] [review]
tests: Test behaviour of the GLOB operator

Removing obsolete, it seems I used « git bz » wrong.
Comment 14 Mathieu Bridon 2014-11-25 09:25:13 UTC
Comment on attachment 291439 [details] [review]
tests: Test behaviour of the GLOB operator

No idea why « git bz » attached this patch a second time, marking as obsolete.
Comment 15 Mathieu Bridon 2014-11-25 09:25:18 UTC
Comment on attachment 291440 [details] [review]
filter: Support the GLOB operator from SQLite

No idea why « git bz » attached this patch a second time, marking as obsolete.