GNOME Bugzilla – Bug 740632
Propagate XDG_CONFIG_DIRS and XCURSOR_PATH
Last modified: 2014-11-29 14:38:00 UTC
Created attachment 291370 [details] [review] gdm_propagated_env.patch In NixOS we extensively use environment variables. In particular, we use XDG_CONFIG_DIRS to point to gnome settings daemon /etc/xdg, and XCURSOR_PATH obviously for the cursors being in the new adwaita icon theme[1]. Hope this trivial patch can be included in GDM. Thanks. [1] https://github.com/lethalman/nixpkgs/blob/gnome314/nixos/modules/services/x11/display-managers/gdm.nix#L54
Review of attachment 291370 [details] [review]: after you make below changes feel free to push. ::: daemon/gdm-launch-environment.c @@ +221,3 @@ "LC_COLLATE", "LC_MONETARY", "LC_MESSAGES", "LC_PAPER", "LC_NAME", "LC_ADDRESS", "LC_TELEPHONE", "LC_MEASUREMENT", + "LC_IDENTIFICATION", "LC_ALL", "WINDOWPATH", "XCURSOR_PATH", I guess this is okay... @@ +253,3 @@ g_free (system_data_dirs); + system_config_dirs = g_strjoinv (":", (char **) g_get_system_config_dirs ()); I know you're trying to model what we're doing with system_data_dirs, but I think i'd rather you just add it up above like you add XCURSOR_PATH. The datadirs code is there because we have to append and item to the search path. Since we don't have to do that for XDG_CONFIG_DIRS, i'd like to avoid the code.
Created attachment 291739 [details] [review] Propagated more env variables in gdm Thanks. New patch, will push it in a few hours.
commit d816c19562b01f5a85fb61c8cb90e5b23fd04ca5 Author: Luca Bruno <lucabru@src.gnome.org> Date: Sat Nov 29 15:13:42 2014 +0100 launch-environment: Propagate XCURSOR_PATH and XDG_CONFIG_DIRS https://bugzilla.gnome.org/show_bug.cgi?id=740632 Cherry picked in gnome-3-14 as 04b24dda59e24eebe14cccddb7d7da6236624f44 This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.