GNOME Bugzilla – Bug 740615
alsa: warn on buffer underrun / overrun
Last modified: 2014-11-24 15:46:54 UTC
Alsa plugins report buffer under / over run at debug level. This problem is user visible and should be logged as warning. Pulse audio plugin warns about them too.
Created attachment 291347 [details] [review] alsa-warning-on-buffer-underrun.patch
This changes the log messages in xrun_recovery() from DEBUG to WARNING. Which makes sense since that function runs when there is an error. Could you edit the commit message to follow the guidelines? Check other commits to see their messages for reference. For example, http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=b9992e43475265a4da2ae4aae0128fec12d9bfc2. Format is like this: area: summary description url-to-bugzilla
Created attachment 291356 [details] [review] 0002-alsa-Change-the-log-messages-in-xrun_recovery-from-D.patch
Created attachment 291358 [details] [review] 0001-alsasrc-Fix-indent-in-gst_alsasrc_prepare-to-make-gi.patch Cleanup patch for alsasrc that I carry in git to make git hook happy.
We don't generally accept indentation/style patches unless you are touching the code for something else. Could you resubmit the second patch but independently? Without the "[Patch 1/2]" in the subject? Thanks.
I need the first commit to be able to make the second commit in git. Do you want me to hand edit the second commit? I can do it, by it feels weird to me.
You can also apply the 0002-... commit on its own. There is not trace of 0002 in the patch. It is just the file name.
Merge the two patches into one and I will merge.
Created attachment 291375 [details] [review] 0001-alsa-Change-the-log-messages-in-xrun_recovery-from-D.patch
Merged commit 5e8e6276cd9e572473741726d00deddff0ae8ff9
Thanks Branislav! :)
Thank you !